Symintifying slice ops #85196

Krovatkin · 2022-09-16T23:44:36Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2022-09-16T23:44:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85196

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 698e8ef:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: c29710e68c31b61d63087d5a28bfd68e0f3beed6 Pull Request resolved: #85196

ezyang · 2022-09-17T03:19:35Z

Testing?

[ghstack-poisoned]

ghstack-source-id: c385820d98ff186b0ba40e3bc25ead4e3caab508 Pull Request resolved: #85196

[ghstack-poisoned]

ghstack-source-id: ad285f4c3841cd043d6046728e6e9cc579cf5e1e Pull Request resolved: #85196

[ghstack-poisoned]

ghstack-source-id: 50879dfed96d3bc0d9e7a0157702f78e2d2ab958 Pull Request resolved: #85196

ezyang · 2022-09-20T04:57:28Z

test/lazy/test_ts_opinfo.py

@@ -175,7 +176,8 @@ def get_name(op):
        torch._lazy.mark_step()
        torch._lazy.wait_device_ops()
        prefix = "aten" if op.name in FALLBACK_LIST else "lazy"
-        found = f"{prefix}::{op.name}" in remove_suffixes(torch._lazy.metrics.counter_names())
+        symint_suffix = "_symint" if op.name in HAS_SYMINT_SUFFIX else ""
+        found = f"{prefix}::{op.name}{symint_suffix}" in remove_suffixes(torch._lazy.metrics.counter_names())


This is better than https://github.com/pytorch/pytorch/pull/85264/files#diff-222fb8e63ff517f76308939550ca744de90dd6ea5706e2afd3f72db019df9b90

[ghstack-poisoned]

ghstack-source-id: 2a2518e3c43a34db7a19386a8538093ec6bac249 Pull Request resolved: #85196

[ghstack-poisoned]

ghstack-source-id: 13554fb4ff2a894fa1bca9b6bc393db4a6d799fb Pull Request resolved: #85196

[ghstack-poisoned]

ezyang · 2022-09-21T21:01:04Z

test/test_decomp.py

+                ]:
+                    yield i
+        slice = SliceOpInfo()
+        self.do_cross_ref('cpu', torch.float, slice, run_all=True)


Weren't you going to move this into common_methods_invocations

it blows up spectacularly in #85314. I'd suggest we do it as a follow up if you don't mind. I'm usually pretty good at following up, lol :)

but... like... that the OpInfo isn't working with the other tests implies that the OpInfo is wrong...

but... like... that the OpInfo isn't working with the other tests implies that the OpInfo is wrong...

It seems it just needs way more integration work to run all the tests we run with OpInfos

there are issues using torch.ops.aten.slice as OpInfo.op

it actually passes for more types than I specified

it also passes more forward/backward tests than I specified it should be passing.

For testing the forward of slice which I think was the main intent of Will's tests, it works pretty well as the part of decomp tests?

I don't think it is going to be that hard to fix. I'm checking out your PR to try it.

ezyang · 2022-09-21T21:01:25Z

torch/_decomp/decompositions.py

@@ -13,6 +14,8 @@
 from torch._prims_common.wrappers import out_wrapper
 from torch.utils._pytree import tree_flatten, tree_map

+old_slice = slice


[ghstack-poisoned]

ghstack-source-id: cac74891e54d687d10138ff63127c34021c27b20 Pull Request resolved: #85196 slice tests rename slice to avoid hijacking builtins.slice fix lintrunner remove dead code stuff fix bbrks

[ghstack-poisoned]

ghstack-source-id: 886e4bd49a09b74c949e779f547267ccfe31be87 Pull Request resolved: #85196 slice tests rename slice to avoid hijacking builtins.slice fix lintrunner remove dead code stuff fix bbrks

ezyang · 2022-09-23T20:39:38Z

@pytorchbot merge

pytorchmergebot · 2022-09-23T20:40:58Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-23T22:02:16Z

Hey @Krovatkin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

bdhirsh · 2022-09-27T14:47:09Z

torch/_decomp/decompositions.py

@@ -609,6 +610,58 @@ def slice_backward(
    return torch.slice_scatter(grad_input, grad_output, dim, start, end, step)


+@register_decomposition(aten.slice.Tensor)
+def slice_forward(


dumb q: why do we need a python decomp for slice if we're already c10::SymInt-ifying the C++ implementation? Is the python impl still required for something? (either way, I totally see a python impl being useful to have).

Look over the patch carefully. We did not, in fact, SymInt'ify the C++ implementation.

welp, thanks. Needed to scan the codegen again to remember how it works: If we put _symint at the end of the kernel name in native_functions.yaml, then the codegen will expect you to symint-ify the C++ kernel

atalman · 2022-09-27T17:58:12Z

@pytorchmergebot revert -m "Break internal build Exutorch" -c ghfirst

pytorchmergebot · 2022-09-27T18:01:24Z

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-27T18:01:30Z

@Krovatkin your PR has been successfully reverted.

This reverts commit 4c01c51. Reverted #85196 on behalf of https://github.com/atalman due to Break internal build Exutorch

This reverts commit 3a171df. [ghstack-poisoned]

This reverts commit 3a171df. ghstack-source-id: 0e11cbd111a5090eb423d6746d646af23a74a1fe Pull Request resolved: #85746

This reverts commit 3a171df. [ghstack-poisoned]

This reverts commit 3a171df. ghstack-source-id: c7d350d19ee10c5f1f133f341c5e380525e0fc5b Pull Request resolved: #85746

This reverts commit 3a171df. Pull Request resolved: #85746 Approved by: https://github.com/albanD

This reverts commit 3a171df. Pull Request resolved: pytorch#85746 Approved by: https://github.com/albanD

Pull Request resolved: #85196 Approved by: https://github.com/ezyang

This reverts commit 4c01c51. Reverted #85196 on behalf of https://github.com/atalman due to Break internal build Exutorch

This reverts commit 3a171df. Pull Request resolved: #85746 Approved by: https://github.com/albanD

Pull Request resolved: pytorch#85196 Approved by: https://github.com/ezyang

This reverts commit 4c01c51. Reverted pytorch#85196 on behalf of https://github.com/atalman due to Break internal build Exutorch

This reverts commit 3a171df. Pull Request resolved: pytorch#85746 Approved by: https://github.com/albanD

Symintifying slice ops

7d69dac

[ghstack-poisoned]

Krovatkin requested review from albanD and soulitzer as code owners September 16, 2022 23:44

Krovatkin mentioned this pull request Sep 16, 2022

remove symintnode bits in LTC #85171

Closed

This was referenced Sep 16, 2022

symintify embedding_dense_backward #85172

Closed

allow compositeImplicitDispatch on symint kernels #85173

Closed

embedding_backward #85174

Closed

facebook-github-bot added the cla signed label Sep 16, 2022

Krovatkin added a commit that referenced this pull request Sep 16, 2022

Symintifying slice ops

db7d934

ghstack-source-id: c29710e68c31b61d63087d5a28bfd68e0f3beed6 Pull Request resolved: #85196

Krovatkin requested a review from ezyang September 17, 2022 00:03

Update on "Symintifying slice ops"

e5e7088

[ghstack-poisoned]

Krovatkin added a commit that referenced this pull request Sep 19, 2022

Symintifying slice ops

641c10f

ghstack-source-id: c385820d98ff186b0ba40e3bc25ead4e3caab508 Pull Request resolved: #85196

Update on "Symintifying slice ops"

d54956f

[ghstack-poisoned]

Krovatkin added a commit that referenced this pull request Sep 19, 2022

Symintifying slice ops

dd904d2

ghstack-source-id: ad285f4c3841cd043d6046728e6e9cc579cf5e1e Pull Request resolved: #85196

Update on "Symintifying slice ops"

94e4401

[ghstack-poisoned]

Krovatkin added a commit that referenced this pull request Sep 20, 2022

Symintifying slice ops

9d6575c

ghstack-source-id: 50879dfed96d3bc0d9e7a0157702f78e2d2ab958 Pull Request resolved: #85196

ezyang reviewed Sep 20, 2022

View reviewed changes

Update on "Symintifying slice ops"

58881b7

[ghstack-poisoned]

Krovatkin added a commit that referenced this pull request Sep 20, 2022

Symintifying slice ops

e0e8242

ghstack-source-id: 2a2518e3c43a34db7a19386a8538093ec6bac249 Pull Request resolved: #85196

ezyang mentioned this pull request Sep 21, 2022

Symbolic shapes #84246

Closed

Update on "Symintifying slice ops"

c92f695

[ghstack-poisoned]

Krovatkin added a commit that referenced this pull request Sep 21, 2022

Symintifying slice ops

84eb0d6

ghstack-source-id: 13554fb4ff2a894fa1bca9b6bc393db4a6d799fb Pull Request resolved: #85196

Update on "Symintifying slice ops"

fc779c8

[ghstack-poisoned]

pytorch-bot bot added the release notes: vulkan release notes category label Sep 21, 2022

Update on "Symintifying slice ops"

5d1fb31

[ghstack-poisoned]

ezyang reviewed Sep 21, 2022

View reviewed changes

Update on "Symintifying slice ops"

dadc448

[ghstack-poisoned]

Update on "Symintifying slice ops"

af62ab7

[ghstack-poisoned]

Update on "Symintifying slice ops"

698e8ef

[ghstack-poisoned]

pytorchmergebot added the Merged label Sep 23, 2022

pytorchmergebot closed this in 4c01c51 Sep 23, 2022

facebook-github-bot deleted the gh/Krovatkin/21/head branch September 27, 2022 14:19

bdhirsh reviewed Sep 27, 2022

View reviewed changes

pytorchmergebot added the Reverted label Sep 27, 2022

pytorchmergebot added a commit that referenced this pull request Sep 27, 2022

Revert "Symintifying slice ops (#85196)"

3a171df

This reverts commit 4c01c51. Reverted #85196 on behalf of https://github.com/atalman due to Break internal build Exutorch

ezyang added a commit that referenced this pull request Sep 27, 2022

Revert "Revert "Symintifying slice ops (#85196)""

d6c69df

This reverts commit 3a171df. [ghstack-poisoned]

ezyang added a commit that referenced this pull request Sep 27, 2022

Revert "Revert "Symintifying slice ops (#85196)""

c4e32a1

This reverts commit 3a171df. ghstack-source-id: 0e11cbd111a5090eb423d6746d646af23a74a1fe Pull Request resolved: #85746

ezyang added a commit that referenced this pull request Sep 27, 2022

Update on "Revert "Revert "Symintifying slice ops (#85196)"""

370f0b0

This reverts commit 3a171df. [ghstack-poisoned]

ezyang added a commit that referenced this pull request Sep 27, 2022

Revert "Revert "Symintifying slice ops (#85196)""

810d473

This reverts commit 3a171df. ghstack-source-id: c7d350d19ee10c5f1f133f341c5e380525e0fc5b Pull Request resolved: #85746

pytorchmergebot pushed a commit that referenced this pull request Sep 28, 2022

Revert "Revert "Symintifying slice ops (#85196)"" (#85746)

793488c

This reverts commit 3a171df. Pull Request resolved: #85746 Approved by: https://github.com/albanD

drisspg pushed a commit to drisspg/pytorch that referenced this pull request Sep 29, 2022

Revert "Revert "Symintifying slice ops (pytorch#85196)"" (pytorch#85746)

700e7b9

This reverts commit 3a171df. Pull Request resolved: pytorch#85746 Approved by: https://github.com/albanD

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Symintifying slice ops (#85196)

77ab8ca

Pull Request resolved: #85196 Approved by: https://github.com/ezyang

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Revert "Symintifying slice ops (#85196)"

209f0f6

This reverts commit 4c01c51. Reverted #85196 on behalf of https://github.com/atalman due to Break internal build Exutorch

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Revert "Revert "Symintifying slice ops (#85196)"" (#85746)

cba3588

This reverts commit 3a171df. Pull Request resolved: #85746 Approved by: https://github.com/albanD

alvgaona pushed a commit to alvgaona/pytorch that referenced this pull request Oct 11, 2022

Symintifying slice ops (pytorch#85196)

035834b

Pull Request resolved: pytorch#85196 Approved by: https://github.com/ezyang

alvgaona pushed a commit to alvgaona/pytorch that referenced this pull request Oct 11, 2022

Revert "Symintifying slice ops (pytorch#85196)"

c8fe87f

This reverts commit 4c01c51. Reverted pytorch#85196 on behalf of https://github.com/atalman due to Break internal build Exutorch

alvgaona pushed a commit to alvgaona/pytorch that referenced this pull request Oct 11, 2022

Revert "Revert "Symintifying slice ops (pytorch#85196)"" (pytorch#85746)

740ddb8

This reverts commit 3a171df. Pull Request resolved: pytorch#85746 Approved by: https://github.com/albanD

malfet mentioned this pull request Nov 2, 2022

malfet/wip symshape ctrl flow #88356

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Symintifying slice ops #85196

Symintifying slice ops #85196

Krovatkin commented Sep 16, 2022 •

edited by ezyang

pytorch-bot bot commented Sep 16, 2022 •

edited

ezyang commented Sep 17, 2022

ezyang Sep 20, 2022

ezyang Sep 21, 2022

Krovatkin Sep 21, 2022 •

edited

ezyang Sep 21, 2022

Krovatkin Sep 21, 2022 •

edited

ezyang Sep 23, 2022

ezyang Sep 21, 2022

ezyang commented Sep 23, 2022

pytorchmergebot commented Sep 23, 2022

github-actions bot commented Sep 23, 2022

bdhirsh Sep 27, 2022

ezyang Sep 27, 2022

bdhirsh Sep 27, 2022

atalman commented Sep 27, 2022

pytorchmergebot commented Sep 27, 2022

pytorchmergebot commented Sep 27, 2022

Symintifying slice ops #85196

Symintifying slice ops #85196

Conversation

Krovatkin commented Sep 16, 2022 • edited by ezyang

pytorch-bot bot commented Sep 16, 2022 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85196

✅ No Failures

ezyang commented Sep 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krovatkin Sep 21, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Krovatkin Sep 21, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ezyang commented Sep 23, 2022

pytorchmergebot commented Sep 23, 2022

github-actions bot commented Sep 23, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atalman commented Sep 27, 2022

pytorchmergebot commented Sep 27, 2022

pytorchmergebot commented Sep 27, 2022

Krovatkin commented Sep 16, 2022 •

edited by ezyang

pytorch-bot bot commented Sep 16, 2022 •

edited

Krovatkin Sep 21, 2022 •

edited

Krovatkin Sep 21, 2022 •

edited