Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parameters check for mkldnn_transpose #85318

Closed
wants to merge 5 commits into from
Closed

add parameters check for mkldnn_transpose #85318

wants to merge 5 commits into from

Conversation

XiaobingSuper
Copy link
Collaborator

@XiaobingSuper XiaobingSuper commented Sep 20, 2022 •
edited

Stack from ghstack (oldest at bottom):

This PR is about add parameters check for mkldnn_transpose, fixed #85216.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85318

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ff84445:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XiaobingSuper added a commit that referenced this pull request Sep 20, 2022
@XiaobingSuper
add parameters check for mkldnn_transpose
959f6ad 
ghstack-source-id: 75650a65cc80c696e0a2acec1af5e7f715dc401c
Pull Request resolved: #85318
@XiaobingSuper XiaobingSuper linked an issue Sep 20, 2022 that may be closed by this pull request
Segmentation fault in _mkldnn_transpose #85216
Closed
@XiaobingSuper
Update on "add parameters check for mkldnn_transpose"
7eae2bc 
This PR is about add parameters check for mkldnn_transpose, fixed #85216.

[ghstack-poisoned]
XiaobingSuper added a commit that referenced this pull request Sep 20, 2022
@XiaobingSuper
add parameters check for mkldnn_transpose
5d9d1a5 
ghstack-source-id: d2a0e6edec22f85e8209adc83c35f299bb87f3c9
Pull Request resolved: #85318
@XiaobingSuper
Update on "add parameters check for mkldnn_transpose"
b86bbb8 
This PR is about add parameters check for mkldnn_transpose, fixed #85216.

[ghstack-poisoned]
XiaobingSuper added a commit that referenced this pull request Sep 20, 2022
@XiaobingSuper
add parameters check for mkldnn_transpose
bd5210c 
ghstack-source-id: c4c861aed19dc76153e504b26b25f984e2641b0a
Pull Request resolved: #85318
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2022
@zhuhaozhe zhuhaozhe closed this Oct 20, 2022
@XiaobingSuper XiaobingSuper reopened this Oct 20, 2022
@XiaobingSuper
Update on "add parameters check for mkldnn_transpose"
ce6aee3 
This PR is about add parameters check for mkldnn_transpose, fixed #85216.

[ghstack-poisoned]
XiaobingSuper added a commit that referenced this pull request Oct 20, 2022
@XiaobingSuper
add parameters check for mkldnn_transpose
765264c 
ghstack-source-id: f924d419dd12f56b8c0952a57062c1e1edf6eeef
Pull Request resolved: #85318
@XiaobingSuper
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
zhangxy988, gchanan, Babar, fbbradheintz, rmaz, ...

Details for Dev Infra team Raised by workflow job

@XiaobingSuper
Update on "add parameters check for mkldnn_transpose"
ff84445 
This PR is about add parameters check for mkldnn_transpose, fixed #85216.

[ghstack-poisoned]
XiaobingSuper added a commit that referenced this pull request Oct 31, 2022
@XiaobingSuper
add parameters check for mkldnn_transpose
faa2426 
ghstack-source-id: 1fc0df8bb0ae7d63fca389ed2a02ac23ace25155
Pull Request resolved: #85318
@mingfeima mingfeima requested a review from jgong5 October 31, 2022 02:29
@XiaobingSuper XiaobingSuper requested review from mingfeima and leslie-fang-intel and removed request for jgong5 October 31, 2022 02:29
@XiaobingSuper XiaobingSuper added the release notes: intel release notes category label Oct 31, 2022
@XiaobingSuper
Copy link
Collaborator Author

@pytorchbot merge

1 similar comment
@XiaobingSuper
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
c-odrin, frankseide, aruntonic, chauhang, smessmer, ...

Details for Dev Infra team Raised by workflow job

@pytorch pytorch deleted a comment from pytorchmergebot Nov 2, 2022
@malfet
Copy link
Contributor

malfet commented Nov 3, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@XiaobingSuper @kulinseth
add parameters check for mkldnn_transpose (pytorch#85318)
7c26fce 
This PR is about add parameters check for mkldnn_transpose, fixed pytorch#85216.
Pull Request resolved: pytorch#85318
Approved by: https://github.com/jgong5, https://github.com/mingfeima, https://github.com/leslie-fang-intel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@XiaobingSuper @kulinseth
add parameters check for mkldnn_transpose (pytorch#85318)
2fd3ee1 
This PR is about add parameters check for mkldnn_transpose, fixed pytorch#85216.
Pull Request resolved: pytorch#85318
Approved by: https://github.com/jgong5, https://github.com/mingfeima, https://github.com/leslie-fang-intel
@facebook-github-bot facebook-github-bot deleted the gh/XiaobingSuper/12/head branch June 8, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgong5 jgong5 jgong5 approved these changes

@mingfeima mingfeima mingfeima approved these changes

@leslie-fang-intel leslie-fang-intel leslie-fang-intel approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged open source release notes: intel release notes category
Projects
PyTorch Intel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault in _mkldnn_transpose
8 participants
@XiaobingSuper @facebook-github-bot @pytorchmergebot @malfet @jgong5 @mingfeima @leslie-fang-intel @pytorchbot