Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dim checks for internal embedding_bag functions #85433

Closed

Conversation

kurtamohler
Copy link
Collaborator

Fixes #85213

@kurtamohler kurtamohler added module: crash Problem manifests as a hard crash, as opposed to a RuntimeError module: error checking Bugs related to incorrect/lacking error checking module: embedding labels Sep 21, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85433

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit e48ffff:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Sep 21, 2022
@samdow samdow added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 22, 2022
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kurtamohler (2a9e168)
  • ✅ login: malfet / name: Nikita Shulga (20ecb68)

@malfet
Copy link
Contributor

malfet commented Nov 28, 2022

@pytorchbot rebase

@malfet malfet added the topic: bug fixes topic category label Nov 28, 2022
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/85433/head returned non-zero exit code 1

Rebasing (1/16)
Auto-merging aten/src/ATen/native/EmbeddingBag.cpp
Auto-merging test/test_nn.py
CONFLICT (content): Merge conflict in test/test_nn.py
error: could not apply 2a9e168e7f... Add dim checks for internal `embedding_bag` functions
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 2a9e168e7f... Add dim checks for internal `embedding_bag` functions

Raised by https://github.com/pytorch/pytorch/actions/runs/3568393500

@malfet
Copy link
Contributor

malfet commented Nov 28, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/85433/head returned non-zero exit code 1

Rebasing (1/7)
Auto-merging aten/src/ATen/native/EmbeddingBag.cpp
Auto-merging test/test_nn.py
CONFLICT (content): Merge conflict in test/test_nn.py
error: could not apply 2a9e168e7f... Add dim checks for internal `embedding_bag` functions
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 2a9e168e7f... Add dim checks for internal `embedding_bag` functions

Raised by https://github.com/pytorch/pytorch/actions/runs/3569126478

@kurtamohler
Copy link
Collaborator Author

The xla test failure is upstream

@kurtamohler
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: crash Problem manifests as a hard crash, as opposed to a RuntimeError module: embedding module: error checking Bugs related to incorrect/lacking error checking open source release notes: nn release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault in embedding_bag
6 participants