-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correct __all__ for torch.distributed and torch.cuda submodules #85702
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85702
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 1 PendingAs of commit c4413d9: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: d5bf186e3f44eac0f65c550d2d2e6f0e30aa083e Pull Request resolved: #85702
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from distributed side
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
…ubmodules" [ghstack-poisoned]
ghstack-source-id: 5041e155acfb31ec2f2bcf54ef1ab263083494b8 Pull Request resolved: #85702
__all__ += ["init_rpc", "BackendType", "TensorPipeRpcBackendOptions"] | ||
__all__ = __all__ + api.__all__ + backend_registry.__all__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohan-varma can you confirm if this change looks fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, looks good, thank you!
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @anjali411. |
Stack from ghstack (oldest at bottom):