Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Add support for aten::masked_select on mps (#119) #85818

Closed
wants to merge 2 commits into from
Closed

[MPS] Add support for aten::masked_select on mps (#119) #85818

wants to merge 2 commits into from

Conversation

DenisVieriu97
Copy link
Collaborator

Reuse the index.Tensor_out implementation since it's already expanding the bool/byte indices to long tensors.

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Sep 28, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 28, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85818

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 866af31:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Sep 28, 2022
kulinseth
kulinseth approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased mps_masked_select onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout mps_masked_select && git pull --rebase)

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link

Hey @DenisVieriu97.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@DenisVieriu97 @mehtanirav
[MPS] Add support for aten::masked_select on mps (#119) (#85818)
c473e22 
Reuse the `index.Tensor_out` implementation since it's already expanding the bool/byte indices to long tensors.
Pull Request resolved: #85818
Approved by: https://github.com/kulinseth
@DenisVieriu97 DenisVieriu97 mentioned this pull request Oct 7, 2022
Open
alvgaona pushed a commit to alvgaona/pytorch that referenced this pull request Oct 11, 2022
@DenisVieriu97 @alvgaona
[MPS] Add support for aten::masked_select on mps (pytorch#119) (pytor…
157d64a 
…ch#85818)

Reuse the `index.Tensor_out` implementation since it's already expanding the bool/byte indices to long tensors.
Pull Request resolved: pytorch#85818
Approved by: https://github.com/kulinseth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet Awaiting requested review from malfet

@albanD albanD Awaiting requested review from albanD

@razarmehr razarmehr Awaiting requested review from razarmehr

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) cla signed Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DenisVieriu97 @pytorchmergebot @kulinseth @facebook-github-bot @pytorchbot