Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Remove protocol dataclass #85916

Closed
wants to merge 1 commit into from
Closed

[ONNX] Remove protocol dataclass #85916

wants to merge 1 commit into from

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Sep 29, 2022 •
edited

Remove the _WithOp protocol because it is not used and causes the dataclass GraphContext to not be able to init in some python versions.

Reference to issue of dataclasses Inheriting from Protocol python/cpython#89244

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85916

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 69cfdf9:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 29, 2022
@justinchuby justinchuby added topic: bug fixes topic category module: onnx Related to torch.onnx labels Sep 29, 2022
BowenBao
BowenBao approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference to issue of dataclasses Inheriting from Protocol python/cpython#89244

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2022
@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@justinchuby justinchuby added this to the 1.13.0 milestone Sep 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule ONNX exporter):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@justinchuby @pytorchmergebot
[ONNX] Remove protocol dataclass
69cfdf9 
- Remove the `_WithOp` protocol because it is not used and causes the dataclass GraphContext to not be able to init in some python versions
@pytorchmergebot
Copy link
Collaborator

Successfully rebased justinchu/fix-dataclass onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout justinchu/fix-dataclass && git pull --rebase)

thiagocrepaldi
thiagocrepaldi approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd highly recommend making changes to the CI to make sure this limitation would have caught by the pipelines before merging it

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "Flacky doc test and cuda tests"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@justinchuby @mehtanirav
[ONNX] Remove protocol dataclass (#85916)
439b54e 
Remove the `_WithOp` protocol because it is not used and causes the dataclass `GraphContext` to not be able to init in some python versions.

Reference to issue of dataclasses Inheriting from Protocol python/cpython#89244

Pull Request resolved: #85916
Approved by: https://github.com/BowenBao, https://github.com/abock, https://github.com/thiagocrepaldi
alvgaona pushed a commit to alvgaona/pytorch that referenced this pull request Oct 11, 2022
@justinchuby @alvgaona
[ONNX] Remove protocol dataclass (pytorch#85916)
b52de89 
Remove the `_WithOp` protocol because it is not used and causes the dataclass `GraphContext` to not be able to init in some python versions.

Reference to issue of dataclasses Inheriting from Protocol python/cpython#89244

Pull Request resolved: pytorch#85916
Approved by: https://github.com/BowenBao, https://github.com/abock, https://github.com/thiagocrepaldi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abock abock abock approved these changes

@thiagocrepaldi thiagocrepaldi thiagocrepaldi approved these changes

@BowenBao BowenBao BowenBao approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@justinchuby @pytorchmergebot @BowenBao @abock @thiagocrepaldi @facebook-github-bot @pytorchbot