Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SparseAdam consuming iterator #86210

Closed
wants to merge 1 commit into from
Closed

Fix SparseAdam consuming iterator #86210

wants to merge 1 commit into from

Conversation

ssnl
Copy link
Collaborator

@ssnl ssnl commented Oct 4, 2022

Fixes #86209

@ssnl ssnl requested a review from albanD as a code owner October 4, 2022 16:19
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86210

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 454f003:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SsnL / name: Tongzhou Wang (454f003)

@bdhirsh bdhirsh requested a review from cpuhrsch October 6, 2022 19:53
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 6, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2022
@cpuhrsch cpuhrsch added release notes: sparse release notes category topic: bug fixes topic category labels Oct 6, 2022
@cpuhrsch
Copy link
Contributor

cpuhrsch commented Oct 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2022
@ssnl @facebook-github-bot
Fix SparseAdam consuming iterator (#86210) (#86210)
1a8d4c4 
Summary:
Fixes #86209

Pull Request resolved: #86210
Approved by: https://github.com/cpuhrsch

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/5ed75ec1d7131c1aa65c94669d24dffbcb5d8769

Reviewed By: seemethere

Differential Revision: D40167204

Pulled By: seemethere

fbshipit-source-id: d9aefadf37c99329a8ee0041d1f91deb9a87aa12
@github-actions github-actions bot deleted the SsnL-patch-2 branch April 5, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged open source release notes: sparse release notes category topic: bug fixes topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SparseAdam consume iterator in arg checking
6 participants
@ssnl @cpuhrsch @pytorchmergebot @facebook-github-bot @bdhirsh @pytorchbot