Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiler] record gradient from nnModule #86355

Closed
wants to merge 1 commit into from
Closed

[Profiler] record gradient from nnModule #86355

wants to merge 1 commit into from

Conversation

slgong-fb
Copy link
Contributor

Summary:

  • catch .grad tensor info
  • update data type and check_and_store, etc
  • update unit test case

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39711295

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86355

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a54891b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39711295

slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request Oct 6, 2022
@slgong-fb @facebook-github-bot
[Profiler] record gradient from nnModule (pytorch#86355)
091e003 
Summary:
Pull Request resolved: pytorch#86355

- catch .grad tensor info
- update data type and `check_and_store`, etc
- update unit test case

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39711295

fbshipit-source-id: 901eea6cc742842a7724786a15c04e567b26f207
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39711295

slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request Oct 6, 2022
@slgong-fb @facebook-github-bot
[Profiler] record gradient from nnModule (pytorch#86355)
994d56c 
Summary:
Pull Request resolved: pytorch#86355

- catch .grad tensor info
- update data type and `check_and_store`, etc
- update unit test case

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39711295

fbshipit-source-id: eff27dd0e1d4cd66faaf633635535f6829e0b3e9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39711295

@slgong-fb @facebook-github-bot
[Profiler] record gradient from nnModule (pytorch#86355)
a54891b 
Summary:
Pull Request resolved: pytorch#86355

- catch .grad tensor info
- update data type and `check_and_store`, etc
- update unit test case

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39711295

fbshipit-source-id: 53f335bd5c828dce4752c80439e2dfad7e1cca38
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39711295

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 7, 2022
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Hey @slgong-fb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2022
@slgong-fb @facebook-github-bot
[Profiler] record gradient from nnModule (#86355)
4118f50 
Summary:
Pull Request resolved: #86355

- catch .grad tensor info
- update data type and `check_and_store`, etc
- update unit test case

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39711295

fbshipit-source-id: 49fa5f0159d473b1da8a18a380177e3b6cd51760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaekit chaekit chaekit approved these changes

@robieta robieta Awaiting requested review from robieta

@aaronenyeshi aaronenyeshi Awaiting requested review from aaronenyeshi

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slgong-fb @facebook-github-bot @pytorchmergebot @chaekit