Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13/N] Update gather with CPU/CUDA implementations #86409

Closed
wants to merge 4 commits into from
Closed

[13/N] Update gather with CPU/CUDA implementations #86409

wants to merge 4 commits into from

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Oct 6, 2022 •
edited

Stack from ghstack:

Changes

  • Updates for the gather collective

Context

#86225

Differential Revision: D40181612

This was referenced Oct 6, 2022
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86409

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 64f9d46:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@H-Huang H-Huang mentioned this pull request Oct 6, 2022
Closed
@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Oct 6, 2022
This was referenced Oct 6, 2022
Closed
Closed
Closed
H-Huang added a commit that referenced this pull request Oct 6, 2022
@H-Huang
[13/N] Update gather with CPU/CUDA implementations
83f3b8a 
ghstack-source-id: 7cd5217691ad5cf12411d15f035ebfda000d747a
Pull Request resolved: #86409
H-Huang added a commit that referenced this pull request Oct 7, 2022
@H-Huang
[13/N] Update gather with CPU/CUDA implementations
9291bb9 
ghstack-source-id: af1d9ccdc9dca0080e808b400bbc8096b3a818db
Pull Request resolved: #86409
@H-Huang
Copy link
Member Author

H-Huang commented Oct 7, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@H-Huang H-Huang mentioned this pull request Oct 17, 2022
Closed
This was referenced Nov 2, 2022
Closed
Closed
kwen2501
kwen2501 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@H-Huang H-Huang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 9, 2022
@H-Huang
Copy link
Member Author

H-Huang commented Nov 9, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.2-py3.8 / test (default, 1, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@H-Huang
Copy link
Member Author

H-Huang commented Nov 9, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@H-Huang
Copy link
Member Author

H-Huang commented Nov 10, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@H-Huang @kulinseth
[13/N] Update gather with CPU/CUDA implementations (pytorch#86409)
b8922ce 
Differential Revision: [D40181612](https://our.internmc.facebook.com/intern/diff/D40181612)
Pull Request resolved: pytorch#86409
Approved by: https://github.com/kwen2501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwen2501 kwen2501 kwen2501 approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@awgu awgu Awaiting requested review from awgu

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (c10d) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@H-Huang @pytorchmergebot @kwen2501