Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SubgraphMatcher for case of no anchor found #86421

Closed
wants to merge 2 commits into from
Closed

Fix SubgraphMatcher for case of no anchor found #86421

wants to merge 2 commits into from

Conversation

SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 6, 2022 •
edited

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 6, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86421

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5dad162:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SherlockNoMad added a commit that referenced this pull request Oct 6, 2022
@SherlockNoMad
Fix SubgraphMatch for case of no anchor found
8a96bf0 
ghstack-source-id: 158773ad2b0cf14a9d15e51605ef9569349607bc
Pull Request resolved: #86421
@SherlockNoMad SherlockNoMad changed the title Fix SubgraphMatch for case of no anchor found Fix SubgraphMatcher for case of no anchor found Oct 6, 2022
jerryzh168
jerryzh168 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the fix. would be better if include at least Summary and Test section in #86421 (comment) as well

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2022
SherlockNoMad added a commit that referenced this pull request Oct 6, 2022
@SherlockNoMad
Fix SubgraphMatch for case of no anchor found
5fb70c5 
ghstack-source-id: 43e81f4ad4c9ca4903a82a91191f8900f34ef56e
Pull Request resolved: #86421
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@SherlockNoMad SherlockNoMad mentioned this pull request Oct 7, 2022
Closed
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Hey @SherlockNoMad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 10, 2022
@SherlockNoMad @facebook-github-bot
Fix SubgraphMatcher for case of no anchor found (#86421) (#86421)
76b2ba8 
Summary:
Pull Request resolved: #86421
Approved by: https://github.com/jerryzh168

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2fec853c8796adbf1b6b13fc095b032c5b9ef7b9

Reviewed By: seemethere

Differential Revision: D40196683

Pulled By: seemethere

fbshipit-source-id: a29a1e4a216e47823715062bd7d9a58963c84a06
@xwang233 xwang233 mentioned this pull request Oct 10, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/SherlockNoMad/37/head branch June 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SherlockNoMad @pytorchmergebot @jerryzh168