Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some composite compliance ops for functionalization #86470

Closed
wants to merge 2 commits into from

Conversation

bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Oct 7, 2022

Confirmed that this fixes #86384

cc @tugsbayasgalan

Functionalization should be included in the "isSubclass" checks that we run, for composite operators that have a different path for composite compliance.

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86470

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 5ef1cbc:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 7, 2022
Confirmed that this fixes #86384

cc tugsbayasgalan 

Functionalization should be included in the "isSubclass" checks that we run, for composite operators that have a different path for composite compliance.




[ghstack-poisoned]
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Oct 10, 2022

@pytorchbot merge -f "flaky windows cpu build out of resources"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @bdhirsh.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 11, 2022
)

Summary:
Confirmed that this fixes #86384

cc tugsbayasgalan

Functionalization should be included in the "isSubclass" checks that we run, for composite operators that have a different path for composite compliance.

Pull Request resolved: #86470
Approved by: https://github.com/ezyang, https://github.com/zou3519

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/4a5fdc56ec692fe5e39b8f5d2da6be16434c5a02

Reviewed By: DanilBaibak

Differential Revision: D40232582

Pulled By: DanilBaibak

fbshipit-source-id: 27eab2aa778c4121a3db1f374bc0e63633e9bfd9
Rick0317 pushed a commit to Rick0317/pytorch that referenced this pull request Oct 18, 2022
ghstack-source-id: 09dd37c15c3c3d10cae779fa5eb48c6284d7f44c
Pull Request resolved: pytorch/pytorch#86470
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/320/head branch June 8, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants