-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MaxPool: correct pooling description #86559
Conversation
Typo in torch.fx.Interpreter.fetch_attr docs
Unify and correct the description of what kind of pooling is added in MaxPool2d and MaxPool3d
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86559
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 70004b7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @cherrywoods. |
In the documentation of
nn.MaxPool2d
andnn.MaxPool3d
, the argument description ofpadding
incorrectly states that zero padding is applied. The remainder of the documentation correctly states that negative infinity padding is applied.The documentation of
padding
innn.MaxPool1d
,nn.functional.max_pool1d/2d/3d
is correct.