Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch] Add fmsub to vectrozation primitives #86568

Closed
wants to merge 1 commit into from
Closed

[torch] Add fmsub to vectrozation primitives #86568

wants to merge 1 commit into from

Conversation

efiks
Copy link
Contributor

@efiks efiks commented Oct 10, 2022

Summary: Add fmsub which is similar to fmadd

Test Plan: CI

Differential Revision: D40215267

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86568

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 2401645:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40215267

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40215267

efiks added a commit to efiks/pytorch that referenced this pull request Oct 10, 2022
@efiks
[torch] Add fmsub to vectrozation primitives (pytorch#86568)
863133d 
Summary:
Pull Request resolved: pytorch#86568

Add fmsub  which is similar to fmadd

Test Plan: CI

Differential Revision: D40215267

fbshipit-source-id: 47a65784ef89e3b0ace8ac9a6098380facbc5209
@efiks
Copy link
Contributor Author

efiks commented Oct 10, 2022

/easycla

4 similar comments
@efiks
Copy link
Contributor Author

efiks commented Oct 10, 2022

/easycla

@efiks
Copy link
Contributor Author

efiks commented Oct 10, 2022

/easycla

@efiks
Copy link
Contributor Author

efiks commented Oct 10, 2022

/easycla

@efiks
Copy link
Contributor Author

efiks commented Oct 10, 2022

/easycla

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40215267

efiks added a commit to efiks/pytorch that referenced this pull request Oct 11, 2022
@efiks
[torch] Add fmsub to vectrozation primitives (pytorch#86568)
9dc6555 
Summary:
Pull Request resolved: pytorch#86568

Add fmsub  which is similar to fmadd

Test Plan: CI

Differential Revision: D40215267

fbshipit-source-id: c9e106b16db70c6d026381f3be218d8d4af3c243
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40215267

efiks added a commit to efiks/pytorch that referenced this pull request Oct 18, 2022
@efiks
[torch] Add fmsub to vectrozation primitives (pytorch#86568)
2fad424 
Summary:
Pull Request resolved: pytorch#86568

Add fmsub  which is similar to fmadd

Test Plan: CI

Differential Revision: D40215267

fbshipit-source-id: d505b66dcf37c0465a24e02ade9edc7a083b091e
@ajtulloch
Copy link
Contributor

For completeness can you add the bfloat16 variant as well following the bfloat16 fmadd example?

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 18, 2022
@efiks
[torch] Add fmsub to vectrozation primitives (pytorch#86568)
2401645 
Summary:
Pull Request resolved: pytorch#86568

Add fmsub  which is similar to fmadd

Test Plan: CI

Reviewed By: ajtulloch

Differential Revision: D40215267

fbshipit-source-id: b2c2f680aec8e1ec3d48dd3b5b4519cf00d97d8a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40215267

@efiks
Copy link
Contributor Author

efiks commented Oct 20, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64-mps / Run MPS tests

Details for Dev Infra team Raised by workflow job

@efiks
Copy link
Contributor Author

efiks commented Oct 20, 2022

@pytorchbot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Try @pytorchbot --help for more info.

@efiks
Copy link
Contributor Author

efiks commented Oct 20, 2022

@pytorchbot merge -f "flaky test"

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2022

You are not authorized to force merges to this repository. Please use the regular @pytorchmergebot merge command instead

@malfet
Copy link
Contributor

malfet commented Oct 20, 2022

@pytorchbot merge -f "MPS failures seems to be unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @efiks.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Can't merge closed PR #86568

sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@efiks @sgrigory
[torch] Add fmsub to vectrozation primitives (pytorch#86568)
44954ed 
Summary: Add fmsub  which is similar to fmadd

Test Plan: CI

Differential Revision: D40215267

Pull Request resolved: pytorch#86568
Approved by: https://github.com/ajtulloch, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtulloch ajtulloch ajtulloch approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@efiks @facebook-github-bot @ajtulloch @pytorchmergebot @malfet