-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add 'mps' to the docs of tensor_attributes #86585
Conversation
Since PyTorch supports mps (Apple metal) devices it should be reflected in the documentation.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86585
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 448c503: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @LukasM937, thanks for the update! I'm not sure we want to land this right now though because mps is still a prototype feature. cc @albanD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many other device available. I don't think this list is intended to be exhaustive.
cc @kulinseth
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
@pytorchbot merge -g |
1 similar comment
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Could you fix the lint please? |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
lintrunner advice
Should be solved now. Also since you mention it, shouldn't an exhaustive list be linked? just as an idea though. |
But I understood the issues of maintaining such an list, In this case, I think it makes it more accessible for new users on an M1 machine. |
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @LukasM937. |
@albanD could you add the labels, it looks like I don't have permissions to add them. 'release notes: mps' |
Since PyTorch supports 'mps' (Apple metal) devices it should be reflected in the documentation.