Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add 'mps' to the docs of tensor_attributes #86585

Closed
wants to merge 2 commits into from

Conversation

LukasM937
Copy link
Contributor

Since PyTorch supports 'mps' (Apple metal) devices it should be reflected in the documentation.

Since PyTorch supports mps (Apple metal) devices it should be reflected in the documentation.
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86585

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 448c503:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LukasM937 / name: Lukas Mührke (9aa7288)

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 11, 2022
@soulitzer
Copy link
Contributor

Hi @LukasM937, thanks for the update! I'm not sure we want to land this right now though because mps is still a prototype feature. cc @albanD

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many other device available. I don't think this list is intended to be exhaustive.
cc @kulinseth

@kulinseth
Copy link
Collaborator

There are many other device available. I don't think this list is intended to be exhaustive.
cc @kulinseth
I think it makes sense to add it, still

Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2022
@albanD
Copy link
Collaborator

albanD commented Oct 13, 2022

@pytorchbot merge -g

1 similar comment
@albanD
Copy link
Collaborator

albanD commented Oct 13, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Oct 13, 2022

Could you fix the lint please?

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@LukasM937
Copy link
Contributor Author

Could you fix the lint please?

Should be solved now.

Also since you mention it, shouldn't an exhaustive list be linked? just as an idea though.

@LukasM937
Copy link
Contributor Author

Could you fix the lint please?

Should be solved now.

Also since you mention it, shouldn't an exhaustive list be linked? just as an idea though.

But I understood the issues of maintaining such an list, In this case, I think it makes it more accessible for new users on an M1 machine.

@albanD
Copy link
Collaborator

albanD commented Oct 14, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @LukasM937.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@LukasM937
Copy link
Contributor Author

@albanD could you add the labels, it looks like I don't have permissions to add them.

'release notes: mps'
'topics: documentation'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants