min/max support for SymInt/Floats, finish as_strided/scatter/squeeze() backward symint support #86609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) backward symint support [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86609
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8bd5b66: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 10, 2022
github-actions
bot
requested review from
anjali411,
antoniojkim,
Chillee,
ezyang,
Krovatkin,
miladm and
wconstab
This was referenced Oct 10, 2022
…er/squeeze() backward symint support" [ghstack-poisoned]
|
This is already in master now |
…er/squeeze() backward symint support" [ghstack-poisoned]
|
It looks like #86643 hasn't landed yet? (Separately, seems like CI didn't kick off after I updated this PR for some reason) |
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
bdhirsh
commented
Oct 12, 2022
| @@ -231,8 +232,7 @@ def _make_magic(method, func, py_type): | |||
|
|
|||
| def magic_impl(self, other): | |||
| if method in ["min", "max"]: | |||
| # op = getattr(builtins, method) | |||
| return self | |||
| op = getattr(builtins, method) | |||
There was a problem hiding this comment.
@albanD I could delete this PR, but I noticed this - probably still worth landing?
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
…er/squeeze() backward symint support" [ghstack-poisoned]
albanD
approved these changes
Oct 13, 2022
| @@ -255,12 +255,11 @@ def magic_impl(self, other): | |||
| return py_type(out, self.shape_env) | |||
|
|
|||
| def unary_magic_impl(self): | |||
| if method in ["ceil", "floor"]: | |||
There was a problem hiding this comment.
nit: This one doesn't need to move since it is only used in the if right? The comment can be removed though.
There was a problem hiding this comment.
yep - i'll remove this
…er/squeeze() backward symint support" This PR shouldn't matter too much, but I figured I'd land it instead of deleting. `PySymInt.min/max` are technically broken today, and this fixes them - but it doesn't matter (yet) because nobody is calling `min()` / `max()` on symints from python (they all happen using `std::min/max` in C++, which desugar to lt / gt calls). [ghstack-poisoned]
…er/squeeze() backward symint support" This PR shouldn't matter too much, but I figured I'd land it instead of deleting. `PySymInt.min/max` are technically broken today, and this fixes them - but it doesn't matter (yet) because nobody is calling `min()` / `max()` on symints from python (they all happen using `std::min/max` in C++, which desugar to lt / gt calls). [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shouldn't matter too much, but I figured I'd land it instead of deleting.
PySymInt.min/maxare technically broken today, and this fixes them - but it doesn't matter (yet) because nobody is callingmin()/max()on symints from python (they all happen usingstd::min/maxin C++, which desugar to lt / gt calls).Stack from ghstack (oldest at bottom):