Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prims.clone #86705

Closed
wants to merge 5 commits into from
Closed

Add prims.clone #86705

wants to merge 5 commits into from

Conversation

IvanYashchuk
Copy link
Collaborator

This simple PR adds clone as a primitive.
Current implementation of clone is not supported with nvFuser executor because of empty_like + copy_to.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86705

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit e0ac22f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@IvanYashchuk
Copy link
Collaborator Author

Is it okay to make clone a primitive?

torch/_prims/__init__.py Outdated Show resolved Hide resolved
@mruberry mruberry self-requested a review October 11, 2022 20:04
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making clone a prim makes sense, we should probably target the prims to being functional

Are the test failures related?

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 11, 2022
@IvanYashchuk
Copy link
Collaborator Author

IvanYashchuk commented Oct 12, 2022

Seems related.

=================================== FAILURES ===================================
_____ TestFakeTensorCUDA.test_fake_crossref_backward_amp_roll_cuda_float32 _____
Unexpected success
ERROR [0.169s]: test_make_fx_symbolic_exhaustive_matmul_cpu_float32 (__main__.TestProxyTensorOpInfoCPU)
ValueError: Cannot view a tensor with shape torch.Size([t1.size(0), t1.size(0), t0.size(0)]) and strides (t1.stride(0), 1, t1.size(0)) as a tensor with shape (t1.size(0)**2, t0.size(0))!

@IvanYashchuk
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @IvanYashchuk.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

jjsjann123 pushed a commit to csarofeen/pytorch that referenced this pull request Oct 12, 2022
This simple PR adds `clone` as a primitive.
Current implementation of `clone` is not supported with nvFuser executor because of `empty_like` + `copy_to`.
Pull Request resolved: pytorch#86705
Approved by: https://github.com/mruberry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: primTorch open source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants