-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prims.clone #86705
Add prims.clone #86705
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86705
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 1 PendingAs of commit e0ac22f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Is it okay to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making clone a prim makes sense, we should probably target the prims to being functional
Are the test failures related?
Seems related.
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @IvanYashchuk. |
This simple PR adds `clone` as a primitive. Current implementation of `clone` is not supported with nvFuser executor because of `empty_like` + `copy_to`. Pull Request resolved: pytorch#86705 Approved by: https://github.com/mruberry
This simple PR adds
clone
as a primitive.Current implementation of
clone
is not supported with nvFuser executor because ofempty_like
+copy_to
.