-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch.ormqr
: backward support
#86800
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86800
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bad9ea9: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…taved/differentiable_ormqr
…taved/differentiable_ormqr
…taved/differentiable_ormqr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool code reuse! I left a couple nits.
Could you also add a note in this function saying that the backward is notably slower than that of linalg.qr, so that it doesn't bite people?
After that, feel free to merge
…taved/differentiable_ormqr
…taved/differentiable_ormqr
…taved/differentiable_ormqr
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @nikitaved. |
Seems good to have, especially when neither
a
nortau
requires grads and/or they are pretty small in number.Fixes #86267