[CoreML][ios_crash] Use special throw macro when encountering CoreML API errors #86938
Conversation
…API errors Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug. Differential Revision: [D40351013](https://our.internmc.facebook.com/intern/diff/D40351013/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86938
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 6db2e16: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…API errors Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug. Differential Revision: [D40351013](https://our.internmc.facebook.com/intern/diff/D40351013/) ghstack-source-id: 170345805 Pull Request resolved: #86938
…ing CoreML API errors" Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug. Differential Revision: [D40351013](https://our.internmc.facebook.com/intern/diff/D40351013/) [ghstack-poisoned]
…API errors Pull Request resolved: #86938 Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug. ghstack-source-id: 170376631 Differential Revision: [D40351013](https://our.internmc.facebook.com/intern/diff/D40351013/)
…ing CoreML API errors" Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug. Differential Revision: [D40351013](https://our.internmc.facebook.com/intern/diff/D40351013/) [ghstack-poisoned]
…API errors Pull Request resolved: #86938 Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug. ghstack-source-id: 170451918 Differential Revision: [D40351013](https://our.internmc.facebook.com/intern/diff/D40351013/)
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hey @mcr229. |
Stack from ghstack (oldest at bottom):
Error messages from TORCH_CHECK are stripped during production builds via -DSTRIP_ERROR_MESSAGES. This diff introduces a new macro COREML_CHECK which will always preserve the error message. This macro is used when encountering errors produced by CoreML API calls so that we can heve enough context to debug.
Differential Revision: D40351013