Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables where to have cpu scalar args #87022

Closed
wants to merge 2 commits into from
Closed

Enables where to have cpu scalar args #87022

wants to merge 2 commits into from

Conversation

ngimel
Copy link
Collaborator

@ngimel ngimel commented Oct 16, 2022

This is for decompositions only, no attempt made to have good performance for this case.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87022

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 6c95596:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022
@ezyang
Copy link
Contributor

ezyang commented Oct 17, 2022

check with @eellison if fake tensor needs updates here.

Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default we assume 0-dim cpu scalars dont contribute to output device so this should be fine. and the torchdynamo cross ref tests that (presumably) aren't failing on this PR verify this !

@ngimel
Copy link
Collaborator Author

ngimel commented Oct 17, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped

@mruberry
Copy link
Collaborator

cc @rdspring1 @IvanYashchuk, we were discussing where scalar support

@github-actions
Copy link

Hey @ngimel.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@github-actions github-actions bot deleted the ngimel/where branch April 16, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants