-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables where
to have cpu scalar args
#87022
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87022
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 1 PendingAs of commit 6c95596: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
check with @eellison if fake tensor needs updates here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default we assume 0-dim cpu scalars dont contribute to output device so this should be fine. and the torchdynamo cross ref tests that (presumably) aren't failing on this PR verify this !
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamped
cc @rdspring1 @IvanYashchuk, we were discussing where scalar support |
Hey @ngimel. |
This is for decompositions only, no attempt made to have good performance for this case.