Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kineto][Profiler] Guard event metadata python thread via verbose flag #87096

Closed
wants to merge 1 commit into from

Conversation

aaronenyeshi
Copy link
Member

Summary: For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag.

Test Plan: CI

Reviewed By: robieta, slgong-fb

Differential Revision: D40325815

Pulled By: aaronenyeshi

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87096

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit df9918a:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: aaronenyeshi / name: Aaron Shi (d2fd306)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40325815

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40325815

aaronenyeshi added a commit to aaronenyeshi/pytorch that referenced this pull request Oct 17, 2022
pytorch#87096)

Summary:
Pull Request resolved: pytorch#87096

For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag.

Test Plan: CI

Reviewed By: robieta, slgong-fb

Differential Revision: D40325815

Pulled By: aaronenyeshi

fbshipit-source-id: 61e28d302ecd301b6f59ba954cdadfa8ccd9f513
@slgong-fb slgong-fb self-requested a review October 17, 2022 20:23
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022
@aaronenyeshi
Copy link
Member Author

@pytorchbot rebase -b viable/strict

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #87096, but it was already up to date

aaronenyeshi added a commit to aaronenyeshi/kineto that referenced this pull request Oct 17, 2022
Summary:
X-link: pytorch/pytorch#87096

For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag.

Reviewed By: robieta, slgong-fb

Differential Revision: D40325815

Pulled By: aaronenyeshi

fbshipit-source-id: 8fd0b8178bd91bcbf69efb1d0a42fa1885c32c8f
aaronenyeshi added a commit to aaronenyeshi/pytorch that referenced this pull request Oct 17, 2022
pytorch#87096)

Summary:
Pull Request resolved: pytorch#87096

For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag.

Test Plan: CI

Reviewed By: robieta, slgong-fb

Differential Revision: D40325815

Pulled By: aaronenyeshi

fbshipit-source-id: 94f86a28fb763eadd6eaba322cc93dc08c28b974
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40325815

pytorch#87096)

Summary:
Pull Request resolved: pytorch#87096

For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag.

Test Plan: CI

Reviewed By: robieta, slgong-fb

Differential Revision: D40325815

Pulled By: aaronenyeshi

fbshipit-source-id: 1afb8b1e6f112c7f5dc9ea5f7bec5ea9aedff492
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40325815

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot merge -f

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot merge: error: argument -f/--force: expected one argument

usage: @pytorchbot merge [-g | -f MESSAGE | -l] [-r [{viable/strict,master}]]

Try @pytorchbot --help for more info.

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot merge -f The 1 failing check is unrelated to this diff, it looks like some timeout on MacOS downloading a file.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: 1 failing check is unrelated to this diff, it looks like some timeout on MacOS downloading a file.

usage: @pytorchbot [-h] {merge,revert,rebase,label} ...

Try @pytorchbot --help for more info.

@aaronenyeshi
Copy link
Member Author

@pytorchmergebot merge -f "The 1 failing check is unrelated to this diff, it looks like a timeout on MacOS downloading a file."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @aaronenyeshi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants