-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kineto][Profiler] Guard event metadata python thread via verbose flag #87096
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87096
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
❌ 1 FailuresAs of commit df9918a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D40325815 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D40325815 |
pytorch#87096) Summary: Pull Request resolved: pytorch#87096 For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag. Test Plan: CI Reviewed By: robieta, slgong-fb Differential Revision: D40325815 Pulled By: aaronenyeshi fbshipit-source-id: 61e28d302ecd301b6f59ba954cdadfa8ccd9f513
d2fd306
to
a8b898d
Compare
@pytorchbot rebase -b viable/strict |
@pytorchbot successfully started a rebase job. Check the current status here |
Tried to rebase and push PR #87096, but it was already up to date |
Summary: X-link: pytorch/pytorch#87096 For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag. Reviewed By: robieta, slgong-fb Differential Revision: D40325815 Pulled By: aaronenyeshi fbshipit-source-id: 8fd0b8178bd91bcbf69efb1d0a42fa1885c32c8f
a8b898d
to
82b2248
Compare
pytorch#87096) Summary: Pull Request resolved: pytorch#87096 For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag. Test Plan: CI Reviewed By: robieta, slgong-fb Differential Revision: D40325815 Pulled By: aaronenyeshi fbshipit-source-id: 94f86a28fb763eadd6eaba322cc93dc08c28b974
This pull request was exported from Phabricator. Differential Revision: D40325815 |
pytorch#87096) Summary: Pull Request resolved: pytorch#87096 For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag. Test Plan: CI Reviewed By: robieta, slgong-fb Differential Revision: D40325815 Pulled By: aaronenyeshi fbshipit-source-id: 1afb8b1e6f112c7f5dc9ea5f7bec5ea9aedff492
This pull request was exported from Phabricator. Differential Revision: D40325815 |
82b2248
to
df9918a
Compare
@pytorchmergebot merge -f |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchmergebot merge -f The 1 failing check is unrelated to this diff, it looks like some timeout on MacOS downloading a file. |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchmergebot merge -f "The 1 failing check is unrelated to this diff, it looks like a timeout on MacOS downloading a file." |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @aaronenyeshi. |
Summary: For Python Tracing enabled trace files, this field "python thread": 0 is repeated for every python_function event. This bloats the trace json size for large number of events or deep call stacks. Instead make this metadata guarded by the verbose flag.
Test Plan: CI
Reviewed By: robieta, slgong-fb
Differential Revision: D40325815
Pulled By: aaronenyeshi