[xnnpack][lite-int][graph-build] graph passes and op checking #87128

mcr229 · 2022-10-17T20:35:14Z

Stack from ghstack (oldest at bottom):

-> [xnnpack][lite-int][graph-build] graph passes and op checking #87128

Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation.
This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us.

The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable.

Differential Revision: D39838338

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 170497840 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

pytorch-bot · 2022-10-17T20:35:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87128

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c25dc7e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 170497840 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! ghstack-source-id: 170652463 Pull Request resolved: #87128

salilsdesai

(y)

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 170666250 ghstack-source-id: 170666250 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 170785346 ghstack-source-id: 170785346 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 170826268 ghstack-source-id: 170826268 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 170955754 ghstack-source-id: 170955754 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 171090078 ghstack-source-id: 171090078 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 171097281 ghstack-source-id: 171097281 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 171231761 ghstack-source-id: 171231761 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 171364139 ghstack-source-id: 171364139 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

…ing" Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! [ghstack-poisoned]

Pull Request resolved: #87128 Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. ghstack-source-id: 171415455 ghstack-source-id: 171415455 Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)!

facebook-github-bot · 2022-10-25T22:06:46Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-10-25T22:08:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

github-actions · 2022-10-25T22:26:35Z

Hey @mcr229.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

…h#87128) Beginning of building the xnnpack graph from the torchscript IR. We first massage the torchscript graph using a few graph passes that perform things such as unused self argument removal and constant propagation. This also performs tracing for us so that the model does not have to be prepped by tracing before being lowered by us. The other check we perform is through the torchscript IR to identify any nodes that are not lowerable/supported, and throwing an error to spit out the specific nodes that are not lowerable. Differential Revision: [D39838338](https://our.internmc.facebook.com/intern/diff/D39838338/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39838338/)! Pull Request resolved: pytorch#87128 Approved by: https://github.com/salilsdesai

pytorch-bot bot added the release notes: jit release notes category label Oct 17, 2022

mcr229 requested a review from salilsdesai October 17, 2022 20:35

salilsdesai approved these changes Oct 17, 2022

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022

pytorchmergebot added the Merged label Oct 25, 2022

pytorchmergebot closed this in b013eb5 Oct 25, 2022

facebook-github-bot deleted the gh/mcr229/12/head branch June 8, 2023 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xnnpack][lite-int][graph-build] graph passes and op checking #87128

[xnnpack][lite-int][graph-build] graph passes and op checking #87128

mcr229 commented Oct 17, 2022 •

edited

pytorch-bot bot commented Oct 17, 2022 •

edited

salilsdesai left a comment

facebook-github-bot commented Oct 25, 2022

pytorchmergebot commented Oct 25, 2022

github-actions bot commented Oct 25, 2022

[xnnpack][lite-int][graph-build] graph passes and op checking #87128

[xnnpack][lite-int][graph-build] graph passes and op checking #87128

Conversation

mcr229 commented Oct 17, 2022 • edited

pytorch-bot bot commented Oct 17, 2022 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87128

✅ No Failures

salilsdesai left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Oct 25, 2022

pytorchmergebot commented Oct 25, 2022

Merge started

github-actions bot commented Oct 25, 2022

mcr229 commented Oct 17, 2022 •

edited

pytorch-bot bot commented Oct 17, 2022 •

edited