Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store type(module) in the module stack #87149

Closed

Conversation

SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 17, 2022

Stack from ghstack (oldest at bottom):

  • As requested by quantization team, it prefer storing type(module) in the module stack.
  • Consequently, as module stack gets verbose, we skip printing module stack in the gm.print_readable()

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 17, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87149

Note: Links to docs will display an error until the docs builds have been completed.

❗ 3 Active SEVs

There are 3 currently active SEVs. If your PR is affected, please view them below:

❌ 7 Failures

As of commit 8ba8a4b:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

SherlockNoMad added a commit that referenced this pull request Oct 17, 2022
ghstack-source-id: b7c014e5576155c9200d17ac03006864f175311b
Pull Request resolved: #87149
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot merge -f "flaky macOS CI"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @SherlockNoMad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/SherlockNoMad/48/head branch June 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: fx release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants