Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable isinstance with torch.distributed.ReduceOp #87303

Closed
wants to merge 7 commits into from
Closed

Reenable isinstance with torch.distributed.ReduceOp #87303

wants to merge 7 commits into from

Commits on Oct 19, 2022

  1. Define the ops other than PREMUL_SUM as a static member 

    Ref:
https://stackoverflow.com/questions/40244413/python-static-class-attribute-of-the-class-itself

Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    8a4f648 View commit details
    Browse the repository at this point in the history

  2. remove type hint of ReduceOp from stubfile 

    Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    70bbba4 View commit details
    Browse the repository at this point in the history

  3. remove __members__ from ReduceOp 

    Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    e8b7d1c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. isinstance test 

    Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    8002908 View commit details
    Browse the repository at this point in the history

  2. _make_nccl_premul_sum is in distributed 

    Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    8c25b2f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. missing isinstance 

    Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    2223c28 View commit details
    Browse the repository at this point in the history

  2. fixing __hash__ of ReduceOp 

    I need to get familiar with pybind11 more

Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
    @crcrpar
    crcrpar committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    16bdeae View commit details
    Browse the repository at this point in the history