Fix registration hooks #87369
Fix registration hooks #87369
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87369
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 2 PendingAs of commit ba338ef: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 additional jobs have failed, first few of them are: trunk Details for Dev Infra teamRaised by workflow job |
antoniojkim
force-pushed
the
antoniojkim/fix_registration_hooks
branch
from
3442604
to
ba338ef
Compare
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hey @antoniojkim. |
There is a bug in the implementation of the registration hooks introduced in pytorch#86148 whereby if the hook returns a tensor, then the short circuiting logic: ``` value = hook(self, name, value) or value ``` Raises an exception ``` RuntimeError: Boolean value of Tensor with more than one value is ambiguous ``` Fixing the logic so that it only checks to see if the value is `None` before overriding Fixes pytorch#85837 CC: @albanD @jbschlosser Pull Request resolved: pytorch#87369 Approved by: https://github.com/albanD
There is a bug in the implementation of the registration hooks introduced in #86148 whereby if the hook returns a tensor, then the short circuiting logic:
Raises an exception
Fixing the logic so that it only checks to see if the value is
Nonebefore overridingFixes #85837
CC: @albanD @jbschlosser