Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vulkan] implement abs #87414

Closed
wants to merge 1 commit into from
Closed

[Vulkan] implement abs #87414

wants to merge 1 commit into from

Conversation

cloutier
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 20, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87414

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5ed9da8:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: vulkan release notes category label Oct 20, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cloutier / name: Vincent Cloutier (3251c9d)

@albanD albanD requested a review from SS-JIA October 21, 2022 13:32
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 21, 2022
@kit1980
Copy link
Member

kit1980 commented Nov 23, 2022

@pytorchbot rebase

@kit1980
Copy link
Member

kit1980 commented Nov 23, 2022

@SS-JIA please take a look

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased vulkan-abs onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout vulkan-abs && git pull --rebase)

@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jan 22, 2023
@cloutier
Copy link
Contributor Author

@kit1980 Can you help me get this merged?

@kit1980 kit1980 requested a review from albanD January 23, 2023 20:40
albanD
albanD approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation match the one from tanh so that sounds good to me

@albanD
Copy link
Collaborator

albanD commented Jan 24, 2023

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased vulkan-abs onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout vulkan-abs && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: vulkan release notes category Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cloutier @kit1980 @pytorchmergebot @albanD @pytorchbot