-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[quant][improvement] Check the fixedqparam op qconfig based on backend_config #87425
Conversation
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87425
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 617f19f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6b5227d564479c987e53f27f9f02bd68a63897f8 Pull Request resolved: #87425
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
model = M().eval() | ||
# we set a global default_qconfig, which will be ignored since the backend | ||
# we defined doesn't support anything | ||
qconfig_mapping = QConfigMapping().set_global(default_qconfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what's happening in this test is more like "ensure we skip validation for fixed qparams ops since backend config doesn't support anything"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can change the comment for the test
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 71c0bae5b2f22348064e604c611f433070e0e603 Pull Request resolved: #87425
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: de53d1b61cb10b71225690d69cab039e62e36790 Pull Request resolved: #87425
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 6963394db35ff401339176aaeff704d149f4f810 Pull Request resolved: #87425
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: abf0d7ef47332fd0fdfdda19b9cf41d29af3e6d0 Pull Request resolved: #87425
@pytorchbot merge -g |
Merge failedReason: This PR has internal changes and must be landed via Phabricator Details for Dev Infra teamRaised by workflow job |
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 638e11b2ce621844ea9ac00c209cfbb4cd629fcd Pull Request resolved: #87425
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
Tried to rebase and push PR #87425, but it was already up to date |
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
Successfully rebased |
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 25d225d893d3f7c7992ed4675e0938f841868b65 Pull Request resolved: #87425
@pytorchbot merge |
Merge failedReason: This PR has internal changes and must be landed via Phabricator Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "not sure why this can't land" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: This PR has internal changes and must be landed via Phabricator Details for Dev Infra teamRaised by workflow job |
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 98a3e3fac1210015b55dd788df070374a450bd00 Pull Request resolved: #87425
…d on backend_config" Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40573882](https://our.internmc.facebook.com/intern/diff/D40573882) [ghstack-poisoned]
…d_config Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 11dfd81d1a1334e3ae761fb93946795f8800b618 Pull Request resolved: #87425
@pytorch merge -f "failing test doesn't seem related" |
@pytorchbot merge -f "failing test doesn't seem related" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) are pending/not yet run (Rule
Dig deeper by viewing the pending checks on hud Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "failing test doesn't seem related" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) are pending/not yet run (Rule
Dig deeper by viewing the pending checks on hud Details for Dev Infra teamRaised by workflow job |
/easycla |
@pytorchbot merge -f "failing test doesn't seem related" |
1 similar comment
@pytorchbot merge -f "failing test doesn't seem related" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @jerryzh168. |
…d_config (pytorch#87425) Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: unlinked from diff since it's too hard to land Pull Request resolved: pytorch#87425 Approved by: https://github.com/andrewor14
…d_config (pytorch#87425) Summary: Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig, this allows users to customize the support for fixed qparam ops Test Plan: python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops Reviewers: Subscribers: Tasks: Tags: unlinked from diff since it's too hard to land Pull Request resolved: pytorch#87425 Approved by: https://github.com/andrewor14
Stack from ghstack (oldest at bottom):
Summary:
Previously we hardcoded the supported observers for fixedqparam ops, this PR changes that to take the information from BackendConfig,
this allows users to customize the support for fixed qparam ops
Test Plan:
python test/test_quantization.py TestQuantizeFx.test_change_backend_config_for_fixed_qparam_ops
Reviewers:
Subscribers:
Tasks:
Tags:
unlinked from diff since it's too hard to land