Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ada lovelace (arch 8.9) support #87436

Closed
wants to merge 1 commit into from
Closed

ada lovelace (arch 8.9) support #87436

wants to merge 1 commit into from

Conversation

gregjhogan
Copy link
Contributor

@gregjhogan gregjhogan commented Oct 21, 2022 •
edited

changes required to be able to compile https://github.com/pytorch/vision and https://github.com/nvidia/apex for sm_89 architecture

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87436

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5ce9ce3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 21, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gregjhogan / name: Greg Hogan (434fe1d)

@albanD albanD requested a review from ngimel October 21, 2022 13:27
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 21, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 21, 2022
@ngimel ngimel mentioned this pull request Oct 24, 2022
Closed
@ngimel
Copy link
Collaborator

ngimel commented Oct 24, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/commaai/pytorch.git pull/87436/head:arch-89-support returned non-zero exit code 128

remote: Permission to commaai/pytorch.git denied to pytorchmergebot.
fatal: unable to access 'https://github.com/commaai/pytorch.git/': The requested URL returned error: 403

Raised by https://github.com/pytorch/pytorch/actions/runs/3315084833

@ngimel
Copy link
Collaborator

ngimel commented Oct 24, 2022

@pytorchbot merge -f "low risk change, won't be tested in CI"

@ngimel
Copy link
Collaborator

ngimel commented Oct 24, 2022

@gregjhogan in the future, when PR is approved you can merge it yourself using pytorchbot commands.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@sclarkson
Copy link
Contributor

Might want to add Hopper / sm_90 support here while you're at it, as it is also included in CUDA 11.8.

@gregjhogan
Copy link
Contributor Author

gregjhogan commented Oct 24, 2022 •
edited

Might want to add Hopper / sm_90 support here while you're at it, as it is also included in CUDA 11.8.

I thought about doing this, but I won't be able to test sm_90 support and I found info that seemed to indicate sm_90 support actually requires CUDA 12.0 (edit: seems like this is incorrect info)

@github-actions
Copy link

Hey @gregjhogan.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

malfet
malfet reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Edit] Ignore this, missed indents.

@eqy eqy mentioned this pull request Oct 25, 2022
Closed
sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@gregjhogan @sgrigory
ada lovelace (arch 8.9) support (pytorch#87436)
bcb9ef1 
changes required to be able to compile https://github.com/pytorch/vision and https://github.com/nvidia/apex for `sm_89` architecture
Pull Request resolved: pytorch#87436
Approved by: https://github.com/ngimel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@gregjhogan @kulinseth
ada lovelace (arch 8.9) support (pytorch#87436)
c31e1c0 
changes required to be able to compile https://github.com/pytorch/vision and https://github.com/nvidia/apex for `sm_89` architecture
Pull Request resolved: pytorch#87436
Approved by: https://github.com/ngimel
pytorchmergebot pushed a commit that referenced this pull request Nov 9, 2022
@eqy @pytorchmergebot
Hopper (sm90) support (#87736)
a7420d2 
Essentially a followup of #87436

CC @xwang233 @ptrblck
Pull Request resolved: #87736
Approved by: https://github.com/xwang233, https://github.com/malfet
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@gregjhogan @kulinseth
ada lovelace (arch 8.9) support (pytorch#87436)
dd7c5d2 
changes required to be able to compile https://github.com/pytorch/vision and https://github.com/nvidia/apex for `sm_89` architecture
Pull Request resolved: pytorch#87436
Approved by: https://github.com/ngimel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@eqy @kulinseth
Hopper (sm90) support (pytorch#87736)
2ec59a6 
Essentially a followup of pytorch#87436

CC @xwang233 @ptrblck
Pull Request resolved: pytorch#87736
Approved by: https://github.com/xwang233, https://github.com/malfet
@RyanHir RyanHir mentioned this pull request Mar 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet left review comments

@ngimel ngimel ngimel approved these changes

@fmassa fmassa Awaiting requested review from fmassa

@soumith soumith Awaiting requested review from soumith

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gregjhogan @ngimel @pytorchmergebot @sclarkson @malfet @albanD @pytorchbot