Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSDP][2/N] Remove params_with_grad #87480

Closed
wants to merge 4 commits into from
Closed

Commits on Oct 21, 2022

  1. [FSDP] Remove params_with_grad

    [ghstack-poisoned]
    awgu committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d21b4d1 View commit details
    Browse the repository at this point in the history
  2. Update on "[FSDP][2/N] Remove params_with_grad"

    This PR removes the property `params_with_grad` from `FullyShardedDataParallel`. It was introduced when implementing `clip_grad_norm_()` but was not consistently used. Personally, I do not think it makes sense for `FullyShardedDataParallel` to expose this helper because it is not a common paradigm.
    
    This PR is technically BC-breaking. However, I checked that no one internally is using this API.
    
    
    [ghstack-poisoned]
    awgu committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    cc19a3a View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Update on "[FSDP][2/N] Remove params_with_grad"

    This PR removes the property `params_with_grad` from `FullyShardedDataParallel`. It was introduced when implementing `clip_grad_norm_()` but was not consistently used. Personally, I do not think it makes sense for `FullyShardedDataParallel` to expose this helper because it is not a common paradigm.
    
    This PR is technically BC-breaking. However, I checked that no one internally is using this API.
    
    
    [ghstack-poisoned]
    awgu committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    315aa94 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Update on "[FSDP][2/N] Remove params_with_grad"

    This PR removes the property `params_with_grad` from `FullyShardedDataParallel`. It was introduced when implementing `clip_grad_norm_()` but was not consistently used. Personally, I do not think it makes sense for `FullyShardedDataParallel` to expose this helper because it is not a common paradigm.
    
    This PR is technically BC-breaking. However, I checked that no one internally is using this API.
    
    
    cc @ezyang @gchanan
    
    [ghstack-poisoned]
    awgu committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    d69725e View commit details
    Browse the repository at this point in the history