Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta for meta_fill_ #87493

Closed
wants to merge 5 commits into from
Closed

Fix meta for meta_fill_ #87493

wants to merge 5 commits into from

Conversation

SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 21, 2022 •
edited by pytorchmergebot

Stack from ghstack (oldest at bottom):

Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead.

@SherlockNoMad
Fix meta for meta_fill_
934784f 
[ghstack-poisoned]
@SherlockNoMad SherlockNoMad mentioned this pull request Oct 21, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87493

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 2 Pending

As of commit 7d7e0e1:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@SherlockNoMad SherlockNoMad mentioned this pull request Oct 21, 2022
Closed
eellison
eellison approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 21, 2022
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot rebase

bdhirsh
bdhirsh approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. To bad op infos didn't catch :(

@SherlockNoMad
Copy link
Contributor Author

@pytorchbot rebase

@SherlockNoMad SherlockNoMad mentioned this pull request Oct 21, 2022
Closed
@ezyang
Copy link
Contributor

ezyang commented Oct 21, 2022

test?

@SherlockNoMad
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@SherlockNoMad
Update on "Fix meta for meta_fill_"
8155267 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead. 

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/SherlockNoMad/52/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/87493)

pytorchmergebot pushed a commit that referenced this pull request Oct 21, 2022
@SherlockNoMad
Fix meta for meta_fill_
1bf140f 
ghstack-source-id: b03cd2f52a750681f7fe401361fa0e8d73b1eaf9
Pull Request resolved: #87493
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #87493, but it was already up to date

@SherlockNoMad
Update on "Fix meta for meta_fill_"
9d70cf9 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead. 

[ghstack-poisoned]
SherlockNoMad added a commit that referenced this pull request Oct 22, 2022
@SherlockNoMad
Fix meta for meta_fill_
6fc52d0 
ghstack-source-id: bbc42642458434bfe114386169deaaf19f64126f
Pull Request resolved: #87493
@SherlockNoMad SherlockNoMad removed the ciflow/trunk Trigger trunk jobs on your pull request label Oct 22, 2022
@SherlockNoMad
Update on "Fix meta for meta_fill_"
385a6e5 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead. 

[ghstack-poisoned]
SherlockNoMad added a commit that referenced this pull request Oct 22, 2022
@SherlockNoMad
Fix meta for meta_fill_
f8ebf64 
ghstack-source-id: 186a589bb0d470c0065f52657fcc647f5b28b62b
Pull Request resolved: #87493
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #87493, but it was already up to date

@SherlockNoMad
Update on "Fix meta for meta_fill_"
7d7e0e1 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead. 

[ghstack-poisoned]
SherlockNoMad added a commit that referenced this pull request Oct 22, 2022
@SherlockNoMad
Fix meta for meta_fill_
a3c2025 
ghstack-source-id: 6aacca729c26ee21c3dc746c1ba083323433c847
Pull Request resolved: #87493
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @SherlockNoMad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ezyang
Copy link
Contributor

ezyang commented Oct 22, 2022

Since we rely on opinfo tests, it would be better not to have a one off test, and instead think about how we could test it universally; eg using schema

ezyang pushed a commit that referenced this pull request Oct 23, 2022
@SherlockNoMad @ezyang
Fix meta for meta_fill_
aa865e2 
ghstack-source-id: 6aacca729c26ee21c3dc746c1ba083323433c847
Pull Request resolved: #87493
@ezyang
Copy link
Contributor

ezyang commented Oct 23, 2022

This is an excellent fix, it fixes timm_efficientnet on symbolic-shapes branch

sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@SherlockNoMad @sgrigory
Fix meta for meta_fill_ (pytorch#87493)
3c756e9 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead.
Pull Request resolved: pytorch#87493
Approved by: https://github.com/eellison, https://github.com/bdhirsh
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@SherlockNoMad @kulinseth
Fix meta for meta_fill_ (pytorch#87493)
5279d40 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead.
Pull Request resolved: pytorch#87493
Approved by: https://github.com/eellison, https://github.com/bdhirsh
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@SherlockNoMad @kulinseth
Fix meta for meta_fill_ (pytorch#87493)
b0ae042 
Existing meta_fill_ doesn't correctly reflect the aliasing relationship for aten.fill. A new MetaTensor should be return instead.
Pull Request resolved: pytorch#87493
Approved by: https://github.com/eellison, https://github.com/bdhirsh
@facebook-github-bot facebook-github-bot deleted the gh/SherlockNoMad/52/head branch June 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SherlockNoMad @ezyang @pytorchmergebot @eellison @bdhirsh