Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: support DNNL_GRAPH_CPU_RUNTIME=TBB #87512

Closed
wants to merge 4 commits into from
Closed

build: support DNNL_GRAPH_CPU_RUNTIME=TBB #87512

wants to merge 4 commits into from

Conversation

min-jean-cho
Copy link
Collaborator

Force set cmake DNNL_GRAPH_CPU_RUNTIME as MKLDNN_CPU_RUNTIME to overwrite set(DNNL_GRAPH_CPU_RUNTIME "OMP"), enabling user-specified MKLDNN_CPU_RUNTIME values (OMP (default), TBB) for DNNL_GRAPH_CPU_RUNTIME.

Fixes #87511

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87512

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 2 Pending

As of commit 8d6a1a3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@min-jean-cho
Copy link
Collaborator Author

@ashokei @jgong5 Could you please help with internal review? Thanks.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 22, 2022
@min-jean-cho min-jean-cho marked this pull request as ready for review October 22, 2022 00:50
@min-jean-cho
Copy link
Collaborator Author

Hi @malfet @seemethere, could you please help review this PR? Thanks.

@malfet
Copy link
Contributor

malfet commented Oct 25, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @min-jean-cho.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@min-jean-cho @sgrigory
build: support DNNL_GRAPH_CPU_RUNTIME=TBB (pytorch#87512)
3b7fca8 
Force set cmake `DNNL_GRAPH_CPU_RUNTIME` as `MKLDNN_CPU_RUNTIME` to overwrite [`set(DNNL_GRAPH_CPU_RUNTIME "OMP")`](https://github.com/oneapi-src/oneDNN/blob/d19d0f795c60695bd32f894c6f01771b2dfbe24d/cmake/options.cmake#L65-L67), enabling user-specified `MKLDNN_CPU_RUNTIME` values (`OMP` (default), `TBB`) for `DNNL_GRAPH_CPU_RUNTIME`.

Fixes pytorch#87511
Pull Request resolved: pytorch#87512
Approved by: https://github.com/jgong5, https://github.com/ashokei, https://github.com/malfet
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@min-jean-cho @kulinseth
build: support DNNL_GRAPH_CPU_RUNTIME=TBB (pytorch#87512)
1557040 
Force set cmake `DNNL_GRAPH_CPU_RUNTIME` as `MKLDNN_CPU_RUNTIME` to overwrite [`set(DNNL_GRAPH_CPU_RUNTIME "OMP")`](https://github.com/oneapi-src/oneDNN/blob/d19d0f795c60695bd32f894c6f01771b2dfbe24d/cmake/options.cmake#L65-L67), enabling user-specified `MKLDNN_CPU_RUNTIME` values (`OMP` (default), `TBB`) for `DNNL_GRAPH_CPU_RUNTIME`.

Fixes pytorch#87511
Pull Request resolved: pytorch#87512
Approved by: https://github.com/jgong5, https://github.com/ashokei, https://github.com/malfet
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@min-jean-cho @kulinseth
build: support DNNL_GRAPH_CPU_RUNTIME=TBB (pytorch#87512)
eac8cca 
Force set cmake `DNNL_GRAPH_CPU_RUNTIME` as `MKLDNN_CPU_RUNTIME` to overwrite [`set(DNNL_GRAPH_CPU_RUNTIME "OMP")`](https://github.com/oneapi-src/oneDNN/blob/d19d0f795c60695bd32f894c6f01771b2dfbe24d/cmake/options.cmake#L65-L67), enabling user-specified `MKLDNN_CPU_RUNTIME` values (`OMP` (default), `TBB`) for `DNNL_GRAPH_CPU_RUNTIME`.

Fixes pytorch#87511
Pull Request resolved: pytorch#87512
Approved by: https://github.com/jgong5, https://github.com/ashokei, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jgong5 jgong5 jgong5 approved these changes

@ashokei ashokei ashokei approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: failure when building pytorch with TBB
6 participants
@min-jean-cho @malfet @pytorchmergebot @jgong5 @ashokei @pytorchbot