Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 64bit indexing in vol2col #87527

Closed
wants to merge 2 commits into from
Closed

Fix 64bit indexing in vol2col #87527

wants to merge 2 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Oct 22, 2022

Surfaced from #87354

CC @ngimel @ptrblck @maybeLee

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 22, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87527

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 4f311b6:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Oct 22, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 22, 2022
@ngimel
Copy link
Collaborator

ngimel commented Oct 23, 2022

@pytorchbot merge -f "test failures unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @eqy.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@dagitses dagitses mentioned this pull request Oct 24, 2022
Closed
sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@eqy @sgrigory
Fix 64bit indexing in vol2col (pytorch#87527)
afe8c2e 
Surfaced from pytorch#87354

CC @ngimel @ptrblck @maybeLee
Pull Request resolved: pytorch#87527
Approved by: https://github.com/ngimel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@eqy @kulinseth
Fix 64bit indexing in vol2col (pytorch#87527)
1a9cd6c 
Surfaced from pytorch#87354

CC @ngimel @ptrblck @maybeLee
Pull Request resolved: pytorch#87527
Approved by: https://github.com/ngimel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@eqy @kulinseth
Fix 64bit indexing in vol2col (pytorch#87527)
c235830 
Surfaced from pytorch#87354

CC @ngimel @ptrblck @maybeLee
Pull Request resolved: pytorch#87527
Approved by: https://github.com/ngimel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eqy @ngimel @pytorchmergebot @pytorchbot