Improvements for DDP Optimizer #87549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds support for 'first_bucket_cap' arg, to align bucketing more precisely with DDP, which may start a smaller first bucket - refactors the bucket splitting logic to be cleaner - adds pretty-print for bucket info, and a way to access bucket info from the DDPOptimizer class from a test case or benchmark - dumps debug logs to stdout [ghstack-poisoned]
wconstab
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu and
kwen2501
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87549
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fa66c39: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
added a commit
that referenced
this pull request
Oct 22, 2022
- adds support for 'first_bucket_cap' arg, to align bucketing more precisely with DDP, which may start a smaller first bucket - refactors the bucket splitting logic to be cleaner - adds pretty-print for bucket info, and a way to access bucket info from the DDPOptimizer class from a test case or benchmark - dumps debug logs to stdout ghstack-source-id: 35e76e7acc34229a874830a06a58a1316d37e0b3 Pull Request resolved: #87549
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
bdhirsh,
Chillee,
ezyang,
Krovatkin and
miladm
This PR needs a labelIf your changes are user facing and intended to be a part of release notes, please use a label starting with If not, please add the For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work. |
wconstab
added
topic: not user facing
This was referenced Oct 22, 2022
soumith
approved these changes
Oct 24, 2022
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
sgrigory
pushed a commit
to sgrigory/pytorch
that referenced
this pull request
Oct 28, 2022
- adds support for 'first_bucket_cap' arg, to align bucketing more precisely with DDP, which may start a smaller first bucket - refactors the bucket splitting logic to be cleaner - adds pretty-print for bucket info, and a way to access bucket info from the DDPOptimizer class from a test case or benchmark - dumps debug logs to stdout cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang Pull Request resolved: pytorch#87549 Approved by: https://github.com/soumith
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
- adds support for 'first_bucket_cap' arg, to align bucketing more precisely with DDP, which may start a smaller first bucket - refactors the bucket splitting logic to be cleaner - adds pretty-print for bucket info, and a way to access bucket info from the DDPOptimizer class from a test case or benchmark - dumps debug logs to stdout cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang Pull Request resolved: pytorch#87549 Approved by: https://github.com/soumith
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
- adds support for 'first_bucket_cap' arg, to align bucketing more precisely with DDP, which may start a smaller first bucket - refactors the bucket splitting logic to be cleaner - adds pretty-print for bucket info, and a way to access bucket info from the DDPOptimizer class from a test case or benchmark - dumps debug logs to stdout cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang Pull Request resolved: pytorch#87549 Approved by: https://github.com/soumith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
with DDP, which may start a smaller first bucket
from the DDPOptimizer class from a test case or benchmark
cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang