Revive static_runtime_benchmark build and test #87660
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87660
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9654ddf: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
added
test-config/default
ciflow/trunk
huydhn
changed the title
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
This build uses the wrong BUILD_ENVIRONMENT and hasn't been run for a long time
|
Successfully rebased |
pytorchmergebot
force-pushed
the
fix-status-runtime-benchmark-build
branch
from
18a9a6f
to
9f8ad25
Compare
huydhn
changed the title
huydhn
force-pushed
the
fix-status-runtime-benchmark-build
branch
from
10b1f96
to
34da8e1
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This build uses the wrong BUILD_ENVIRONMENT `pytorch-linux-focal-py3`, thus it hasn't been run for a long time (forgotten). The name was probably the old name of the build environment we used in the past. The convention today doesn't have the `pytorch-` prefix. There is a TODO for this: > TODO: this condition is never (BUILD_ENVIRONMENT doesn't start with pytorch-), need to fix this. This is done as part of [T131829540](https://www.internalfb.com/intern/tasks/?t=131829540), where we want `static_runtime_benchmark` build and test jobs to run in OSS CI to avoid breaking internal * I also fix some compiler warning errors `-Werror=sign-compare`, `-Werror,-Wunused-const-variable`, and gcc7 compatibility issue along the way because this hasn't been run for a long time. * Reviving this test also reveals a small bug in `PrepackWeights` test in `test_static_runtime.cc` added recently in pytorch#85289. The test refers to an internal ops and should only be run internally. This has been fixed by pytorch#87799 (To be merged) Pull Request resolved: pytorch#87660 Approved by: https://github.com/malfet
This build uses the wrong BUILD_ENVIRONMENT
pytorch-linux-focal-py3, thus it hasn't been run for a long time (forgotten). The name was probably the old name of the build environment we used in the past. The convention today doesn't have thepytorch-prefix. There is a TODO for this:This is done as part of T131829540, where we want
static_runtime_benchmarkbuild and test jobs to run in OSS CI to avoid breaking internal-Werror=sign-compare,-Werror,-Wunused-const-variable, and gcc7 compatibility issue along the way because this hasn't been run for a long time.PrepackWeightstest intest_static_runtime.ccadded recently in [Static Runtime] Fold linear prepack ops #85289. The test refers to an internal ops and should only be run internally. This has been fixed by [Static Runtime] Move PrepackWeights to internal-only graph passes #87799 (To be merged)