Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuDNN] (re-open) Enable cuDNN Frontend v8 API by Default #87669

Closed
wants to merge 4 commits into from

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Oct 25, 2022

#58414

Has a small tweak to a test that was breaking on A10 (CC @malfet).

CC @ptrblck @ngimel

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87669

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 10 Pending

As of commit 93ac4d3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Oct 25, 2022
@eqy eqy changed the title [cuDNN] Enable cuDNN Frontend v8 API by Default [cuDNN] (re-open) Enable cuDNN Frontend v8 API by Default Oct 25, 2022
@eqy eqy added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Oct 26, 2022
@eqy
Copy link
Collaborator Author

eqy commented Oct 26, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cudnn_v8_default onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cudnn_v8_default && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Oct 26, 2022

CC @ngimel @malfet Does ciflow/periodic include the previous A10 failure? Otherwise the MPS failure looks unrelated.

@bdhirsh bdhirsh requested review from ngimel and malfet October 27, 2022 14:43
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 27, 2022
@eqy
Copy link
Collaborator Author

eqy commented Oct 31, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/87669/head returned non-zero exit code 1

Rebasing (1/2)
Auto-merging test/test_nn.py
CONFLICT (content): Merge conflict in test/test_nn.py
error: could not apply 8ca4a04b70... use tols for weight grad
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 8ca4a04b70... use tols for weight grad

Raised by https://github.com/pytorch/pytorch/actions/runs/3362794970

@eqy
Copy link
Collaborator Author

eqy commented Oct 31, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cudnn_v8_default onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cudnn_v8_default && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Nov 1, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cudnn_v8_default onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cudnn_v8_default && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Nov 1, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased cudnn_v8_default onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cudnn_v8_default && git pull --rebase)

@eqy
Copy link
Collaborator Author

eqy commented Nov 2, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
)

pytorch#58414

Has a small tweak to a test that was breaking on A10 (CC @malfet).

CC @ptrblck @ngimel
Pull Request resolved: pytorch#87669
Approved by: https://github.com/ngimel
@eqy
Copy link
Collaborator Author

eqy commented Nov 8, 2022

@pytorchbot revert -m "investigating convnext benchmark regressions"

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 8, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@eqy
Copy link
Collaborator Author

eqy commented Nov 8, 2022

@pytorchbot revert -m "investigating convnext benchmark regressions" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@eqy your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 8, 2022
…7669)"

This reverts commit 3c6bddc.

Reverted #87669 on behalf of https://github.com/eqy due to investigating convnext benchmark regressions
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
)

pytorch#58414

Has a small tweak to a test that was breaking on A10 (CC @malfet).

CC @ptrblck @ngimel
Pull Request resolved: pytorch#87669
Approved by: https://github.com/ngimel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
…torch#87669)"

This reverts commit 3c6bddc.

Reverted pytorch#87669 on behalf of https://github.com/eqy due to investigating convnext benchmark regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants