Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed minor typos in torch.flip and torch.rot90 #87724

Closed
wants to merge 1 commit into from
Closed

Fixed minor typos in torch.flip and torch.rot90 #87724

wants to merge 1 commit into from

Conversation

scaomath
Copy link
Contributor

Fixes #87721

@malfet

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: scaomath / name: Shuhao Cao (606a82c)

@pytorch-bot pytorch-bot bot added the release notes: python_frontend release notes category label Oct 25, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87724

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 606a82c:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@scaomath scaomath mentioned this pull request Oct 25, 2022
Closed
malfet
malfet approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As n- tensor is read as ˈɛn/ an an article seems justified.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 25, 2022
@malfet
Copy link
Contributor

malfet commented Oct 25, 2022

@pytorchbot merge -f "This is a docs only change"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @scaomath.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

sgrigory pushed a commit to sgrigory/pytorch that referenced this pull request Oct 28, 2022
@scaomath @sgrigory
Fixed minor typos in torch.flip and torch.rot90 (pytorch#87724)
7d74d61 
Fixes pytorch#87721

@malfet

Pull Request resolved: pytorch#87724
Approved by: https://github.com/malfet
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@scaomath @kulinseth
Fixed minor typos in torch.flip and torch.rot90 (pytorch#87724)
6ea0eff 
Fixes pytorch#87721

@malfet

Pull Request resolved: pytorch#87724
Approved by: https://github.com/malfet
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@scaomath @kulinseth
Fixed minor typos in torch.flip and torch.rot90 (pytorch#87724)
2caad3e 
Fixes pytorch#87721

@malfet

Pull Request resolved: pytorch#87724
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor typo in torch.flip and torch.rot90
4 participants
@scaomath @malfet @pytorchmergebot @pytorchbot