Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support trace on MPS backend #87910

Closed
wants to merge 5 commits into from
Closed

Add support trace on MPS backend #87910

wants to merge 5 commits into from

Conversation

PumeTu
Copy link
Contributor

@PumeTu PumeTu commented Oct 27, 2022

Fixes #87221
trace now supported on MPS

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Oct 27, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 27, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87910

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit e8c33c5:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@PumeTu PumeTu changed the title add support trace on MPS backend Add support trace on MPS backend Oct 27, 2022
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 31, 2022
@PumeTu
Copy link
Contributor Author

PumeTu commented Nov 1, 2022

I added new comments as suggested by the reviewer to switch from CachedGraph to MPSUnaryCachedGraph. Also, would I be able to get some guidance on how to fix the EasyCLA authorization, I haved signed the Contributor document and the error still seems to persist.

kulinseth
kulinseth approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@kulinseth kulinseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@PumeTu
Copy link
Contributor Author

PumeTu commented Nov 8, 2022 •
edited

@kulinseth I moved the trace_mps function to ReduceOps.mm because the output shape was incorrect in TriangularOps.mm, and the comments on the issue also recommended it.

@molssongroup
Copy link

/easycla

@malfet
Copy link
Contributor

malfet commented Nov 10, 2022

@PumeTu please add an email you've authored this PR with to your github registered emails, and then easy CLA should pass

@PumeTu
Copy link
Contributor Author

PumeTu commented Nov 11, 2022

@malfet I was able to fix the CLA check by ammending the first commit to add my email in. All the commits were updated but the content should still be the same and all the functionalities should still work.

@kulinseth
Copy link
Collaborator

@pytorchbot merge -f "MPS is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@PumeTu @kulinseth
Add support trace on MPS backend (pytorch#87910)
9673b16 
Fixes [pytorch#87221](pytorch#87221)
`trace` now supported on MPS

Pull Request resolved: pytorch#87910
Approved by: https://github.com/kulinseth, https://github.com/malfet
@DenisVieriu97 DenisVieriu97 mentioned this pull request Feb 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MPS] Add support for aten::trace for MPS backend
7 participants
@PumeTu @molssongroup @malfet @kulinseth @pytorchmergebot @soulitzer @pytorchbot