-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reland][fx][subgraph_rewriter] Change match_filter to be a List in replace_pattern_with_filters #87998
Conversation
…eplace_pattern_with_filters Summary: att, this is experimental api so not marking it as bc-breaking. The match will be accepted only if all the filters in the list passes. Changing the filter arg to be list also allows us to pass in empty list that means no filter, which makes user code cleaner. Test Plan: python test/test_fx.py -k test_replace_pattern_with_filters Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87998
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 74ded5b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…eplace_pattern_with_filters Summary: att, this is experimental api so not marking it as bc-breaking. The match will be accepted only if all the filters in the list passes. Changing the filter arg to be list also allows us to pass in empty list that means no filter, which makes user code cleaner. Test Plan: python test/test_fx.py -k test_replace_pattern_with_filters Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 191a553e3905dfaa2cb954857918df58c85e4b13 Pull Request resolved: #87998
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…eplace_pattern_with_filters (pytorch#87998) Summary: att, this is experimental api so not marking it as bc-breaking. The match will be accepted only if all the filters in the list passes. Changing the filter arg to be list also allows us to pass in empty list that means no filter, which makes user code cleaner. Test Plan: python test/test_fx.py -k test_replace_pattern_with_filters Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40810943](https://our.internmc.facebook.com/intern/diff/D40810943) Pull Request resolved: pytorch#87998 Approved by: https://github.com/SherlockNoMad
…eplace_pattern_with_filters (pytorch#87998) Summary: att, this is experimental api so not marking it as bc-breaking. The match will be accepted only if all the filters in the list passes. Changing the filter arg to be list also allows us to pass in empty list that means no filter, which makes user code cleaner. Test Plan: python test/test_fx.py -k test_replace_pattern_with_filters Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40810943](https://our.internmc.facebook.com/intern/diff/D40810943) Pull Request resolved: pytorch#87998 Approved by: https://github.com/SherlockNoMad
Stack from ghstack (oldest at bottom):
Summary:
att, this is experimental api so not marking it as bc-breaking.
The match will be accepted only if all the filters in the list passes.
Changing the filter arg to be list also allows us to pass in empty list that means no filter, which makes user code cleaner.
Test Plan:
python test/test_fx.py -k test_replace_pattern_with_filters
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D40810943