Store autocast_gpu_dtype in custom_fwd and custom_bwd for BFloat16 autocast
#88029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88029
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4b580fc: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ngimel
approved these changes
Oct 29, 2022
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…t16 autocast (pytorch#88029) As per pytorch#87979, `custom_bwd` seems to forcefully use `torch.float16` for `torch.autograd.Function.backward` regardless of the `dtype` used in the forward. Changes: - store the `dtype` in `args[0]` - update tests to confirm the dtype of intermediate result tensors that are outputs of autocast compatible `torch` functions cc @ptrblck @ngimel Pull Request resolved: pytorch#88029 Approved by: https://github.com/ngimel
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…t16 autocast (pytorch#88029) As per pytorch#87979, `custom_bwd` seems to forcefully use `torch.float16` for `torch.autograd.Function.backward` regardless of the `dtype` used in the forward. Changes: - store the `dtype` in `args[0]` - update tests to confirm the dtype of intermediate result tensors that are outputs of autocast compatible `torch` functions cc @ptrblck @ngimel Pull Request resolved: pytorch#88029 Approved by: https://github.com/ngimel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #87979,
custom_bwdseems to forcefully usetorch.float16fortorch.autograd.Function.backwardregardless of thedtypeused in the forward.Changes:
dtypeinargs[0]torchfunctionscc @ptrblck @ngimel