Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix github bug issue 87552 #88059

Closed
wants to merge 1 commit into from
Closed

fix github bug issue 87552 #88059

wants to merge 1 commit into from

Conversation

jingxu10
Copy link
Collaborator

Fixes #87552

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88059

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit aaa3d2a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ngimel
ngimel reviewed Oct 31, 2022
View reviewed changes
torch/_tensor_docs.py
@@ -2236,7 +2236,8 @@ def add_docstr_all(method, docstr):
>>> x = torch.randn(3, 4, 5, device='cuda:0')
>>> x.get_device()
0
>>> x.cpu().get_device() # RuntimeError: get_device is not implemented for type torch.FloatTensor
>>> x.cpu().get_device()
-1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also change the doc string at line 2232?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. Done.

@jingxu10
fix github bug issue 87552
aaa3d2a 
fix github bug issue 87552
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2022
@ngimel
Copy link
Collaborator

ngimel commented Oct 31, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link

Hey @jingxu10.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@jingxu10 @kulinseth
fix github bug issue 87552 (pytorch#88059)
2d855e5 
Fixes pytorch#87552
Pull Request resolved: pytorch#88059
Approved by: https://github.com/jgong5, https://github.com/ngimel
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@jingxu10 @kulinseth
fix github bug issue 87552 (pytorch#88059)
9912392 
Fixes pytorch#87552
Pull Request resolved: pytorch#88059
Approved by: https://github.com/jgong5, https://github.com/ngimel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgong5 jgong5 jgong5 approved these changes

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

torch.Tensor.get_device would not be updated for CPU tensors behavior
5 participants
@jingxu10 @ngimel @pytorchmergebot @jgong5 @pytorchbot