-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] hipGraph support for pytorch mainline #88202
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88202
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 394a1b6: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
Rebase failed due to Command
Raised by https://github.com/pytorch/pytorch/actions/runs/3408082704 |
55e2dff
to
1caa540
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes have been tested in our fork of PyTorch with ROCm5.3.
- pytorch#88202 Actual author - Doug Lehr
- pytorch#88202 Actual author - Doug Lehr
- pytorch#88202 Actual author - Doug Lehr
@dllehr-amd Let's take this PR back out of draft when the CI is green and it's ready to be reviewed and merged by PyTorch reviewers. |
- pytorch#88202 Actual author - Doug Lehr
1caa540
to
6ffcf62
Compare
602a146
to
5801541
Compare
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
Successfully rebased |
5801541
to
e41b315
Compare
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
With the release of ROCm 5.3 hip now supports a hipGraph implementation. All necessary backend work and hipification are done to support the same functionality as cudaGraph. Unit tests are modified to support a new TEST_GRAPH feature which allows us to create a single check for graph support instead of attempted to gather the CUDA level in annotations for every graph test
Successfully rebased |
e41b315
to
394a1b6
Compare
Checked the latest CI status: 4 jobs failed: |
@pytorchbot merge -f "Unrelated CI failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
With the release of ROCm 5.3 hip now supports a hipGraph implementation.
All necessary backend work and hipification is done to support the same functionality as cudaGraph.
Unit tests are modified to support a new TEST_GRAPH feature which allows us to create a single check for graph support instead of attempted to gather the CUDA level in annotations for every graph test
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport