Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FX] Add type annotation to getitem node before split_module #88510

Closed
wants to merge 1 commit into from
Closed

[FX] Add type annotation to getitem node before split_module #88510

wants to merge 1 commit into from

Conversation

lequytra
Copy link
Contributor

@lequytra lequytra commented Nov 4, 2022

Summary: Some nodes lost the type annotation during split_module, causing the submodels to be un-scriptable. This is because compiler always infer Tensor type, which is wrong for non-Tensor types. We attempt to infer type annotation for getitem node to improve scriptability.

Test Plan:

buck2 test //caffe2/test:fx_experimental

Differential Revision: D41037819

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 4, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88510

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 01b0eab:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lequytra / name: Tran Le (d3cbc2f)

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 4, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41037819

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41037819

lequytra added a commit to lequytra/pytorch that referenced this pull request Nov 4, 2022
@lequytra @facebook-github-bot
[FX] Add type annotation to getitem node before split_module (pyt…
d3cbc2f 
…orch#88510)

Summary:
Pull Request resolved: pytorch#88510

Some nodes lost the type annotation during `split_module`, causing the submodels to be un-scriptable. This is because compiler always infer Tensor type, which is wrong for non-Tensor types. We attempt to infer type annotation for `getitem` node to improve scriptability.

Test Plan:
```
buck2 test //caffe2/test:fx_experimental
```

Differential Revision: D41037819

fbshipit-source-id: fd388dc4f35264453de482f9278727220a3082ce
@lequytra @facebook-github-bot
[FX] Add type annotation to getitem node before split_module (pyt…
01b0eab 
…orch#88510)

Summary:
Pull Request resolved: pytorch#88510

Some nodes lost the type annotation during `split_module`, causing the submodels to be un-scriptable. This is because compiler always infer Tensor type, which is wrong for non-Tensor types. We attempt to infer type annotation for `getitem` node to improve scriptability.

Test Plan:
```
buck2 test //caffe2/test:fx_experimental
```

Differential Revision: D41037819

fbshipit-source-id: 37ee40e52d0e46a9317d1eec6b469510d7ea34e9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41037819

@xush6528 xush6528 self-requested a review November 8, 2022 18:12
@facebook-github-bot
Copy link
Contributor

@lequytra has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 18, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@lequytra @kulinseth
[FX] Add type annotation to getitem node before split_module (pyt…
a5350a6 
…orch#88510)

Summary: Some nodes lost the type annotation during `split_module`, causing the submodels to be un-scriptable. This is because compiler always infer Tensor type, which is wrong for non-Tensor types. We attempt to infer type annotation for `getitem` node to improve scriptability.

Test Plan:
```
buck2 test //caffe2/test:fx_experimental
```

Differential Revision: D41037819

Pull Request resolved: pytorch#88510
Approved by: https://github.com/xush6528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xush6528 xush6528 xush6528 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lequytra @facebook-github-bot @pytorchmergebot @xush6528