[MPS] Add repeat_interleave to MPS #88649

jazzysoggy · 2022-11-08T03:34:29Z

Implements new repeat_interleave function into aten/src/ATen/native/mps/operations/Repeat.mm
Adds it to aten/src/ATen/native/native_functions.yaml
Adds new test test_repeat_interleave to test/test_mps/py

pytorch-bot · 2022-11-08T03:34:32Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88649

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9229982:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kulinseth

Looks good. @jazzysoggy please fix the lint issue.

kulinseth

@jazzysoggy please fix the lint issue.

Also what you have is just a copy of Repeat.cpp core file. The backend need to implement the aforementioned interface.

aten/src/ATen/native/mps/operations/Repeat.mm

kulinseth

Please fix the Lint error, otherwise it looks good.

kulinseth · 2022-11-16T21:05:17Z

Also there is Build failure:

/Users/runner/work/pytorch/pytorch/aten/src/ATen/native/mps/operations/Repeat.mm:216:105: error: 'NSNumber' may not respond to 'UTF8String' [-Werror]
[3056](https://github.com/pytorch/pytorch/actions/runs/3482646873/jobs/5825210002#step:10:3057)
    string key = "repeat_interleave_mps:" + getTensorsStringKey({repeats})+ ":" + string([repeats_shape UTF8String]);
[3057](https://github.com/pytorch/pytorch/actions/runs/3482646873/jobs/5825210002#step:10:3058)
                                                                                          ~~~~~~~~~~~~~ ^

jazzysoggy · 2022-11-19T01:56:53Z

@kulinseth I think I need a little help. Not quite sure how to properly write a native metal kernel. I think I've got the framework correct, but just not accessing the correct namespaces for certain objects or defining functions in the right places.

kulinseth · 2022-12-12T17:53:17Z

@kulinseth I think I need a little help. Not quite sure how to properly write a native metal kernel. I think I've got the framework correct, but just not accessing the correct namespaces for certain objects or defining functions in the right places.

@jazzysoggy , is this still an issue. Can you please paste the error message you are running into?

jazzysoggy · 2022-12-12T19:09:42Z

@kulinseth I think I need a little help. Not quite sure how to properly write a native metal kernel. I think I've got the framework correct, but just not accessing the correct namespaces for certain objects or defining functions in the right places.

@jazzysoggy , is this still an issue. Can you please paste the error message you are running into?

No, no longer facing this issue anymore. The entire thing compile, just with testing errors now.

‘’FAIL [13.217s]: test_no_warning_on_import (main.TestFallbackWarning)
3541

3542
Traceback (most recent call last):
3543
File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/test_mps.py", line 7033, in test_no_warning_on_import
3544
self.assertEqual(out, "")
3545
File "/Users/ec2-user/runner/_work/_temp/conda_environment_3509465096/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 2555, in assertEqual
3546
assert_equal(
3547
File "/Users/ec2-user/runner/_work/_temp/conda_environment_3509465096/lib/python3.9/site-packages/torch/testing/_comparison.py", line 1118, in assert_equal
3548
raise error_metas[0].to_error(msg)
3549
AssertionError: String comparison failed: '[W OperatorEntry.cpp:159] Warning: Overri[535 chars]l)\n' != ''
3550

[W OperatorEntry.cpp:159] Warning: Overriding a previously registered kernel for the same operator and the same dispatch key
3551
operator: aten::repeat_interleave.Tensor(Tensor repeats, *, int? output_size=None) -> Tensor
3552

registered at /Users/runner/work/pytorch/pytorch/build/aten/src/ATen/RegisterSchema.cpp:6

3553

dispatch key: MPS
3554
previous kernel: registered at /Users/runner/work/pytorch/pytorch/build/aten/src/ATen/RegisterCPU.cpp:30830
3555

   new kernel: registered at /Users/runner/work/pytorch/pytorch/aten/src/ATen/mps/MPSFallback.mm:48 (function registerKernel)

3556’’

jazzysoggy · 2022-12-17T19:45:00Z

@kulinseth I’m able to compile, but I currently have issues with passing the test. Here’s the error log for the failed test

FAIL [13.217s]: test_no_warning_on_import (main.TestFallbackWarning)
3541

3542
Traceback (most recent call last):
3543
File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/test_mps.py", line 7033, in test_no_warning_on_import
3544
self.assertEqual(out, "")
3545
File "/Users/ec2-user/runner/_work/_temp/conda_environment_3509465096/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 2555, in assertEqual
3546
assert_equal(
3547
File "/Users/ec2-user/runner/_work/_temp/conda_environment_3509465096/lib/python3.9/site-packages/torch/testing/_comparison.py", line 1118, in assert_equal
3548
raise error_metas[0].to_error(msg)
3549
AssertionError: String comparison failed: '[W OperatorEntry.cpp:159] Warning: Overri[535 chars]l)\n' != ''
3550

[W OperatorEntry.cpp:159] Warning: Overriding a previously registered kernel for the same operator and the same dispatch key
3551
operator: aten::repeat_interleave.Tensor(Tensor repeats, *, int? output_size=None) -> Tensor
3552

registered at /Users/runner/work/pytorch/pytorch/build/aten/src/ATen/RegisterSchema.cpp:6

3553

dispatch key: MPS
3554
previous kernel: registered at /Users/runner/work/pytorch/pytorch/build/aten/src/ATen/RegisterCPU.cpp:30830
3555

   new kernel: registered at /Users/runner/work/pytorch/pytorch/aten/src/ATen/mps/MPSFallback.mm:48 (function registerKernel)

changeling · 2023-01-26T20:21:15Z

@jazzysoggy Just checking on the status of this. @kulinseth?

changeling · 2023-02-06T20:37:23Z

Any word?

DenisVieriu97 · 2023-02-09T07:14:00Z

@jazzysoggy I've rebased your current branch against latest PyTorch master. Please check the results once the build is finished

DenisVieriu97 · 2023-02-12T03:53:15Z

@jazzysoggy I've fixed the remaining failures and the kernel. Please take a look and merge it when everything is green

DenisVieriu97 · 2023-02-12T05:13:00Z

@pytorchbot merge -g

pytorchmergebot · 2023-02-12T05:16:27Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-02-12T16:26:20Z

Can't merge closed PR #88649

changeling · 2023-02-12T16:30:44Z

Thank y'all for all your work on this one, @jazzysoggy, @DenisVieriu97, @kulinseth! This one is much appreciated. Cheers.

changeling · 2023-02-14T19:30:59Z

@kulinseth Might be a good idea to update #77764 now that this has been implemented. It appears under both Good First Issue and Not categorized. :)

jazzysoggy requested a review from kulinseth as a code owner November 8, 2022 03:34

pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Nov 8, 2022

jazzysoggy changed the title ~~Add repeat_interleave to MPS~~ [MPS] Add repeat_interleave to MPS Nov 8, 2022

pytorchbot added the open source label Nov 8, 2022

kulinseth approved these changes Nov 10, 2022

View reviewed changes

kulinseth requested changes Nov 10, 2022

View reviewed changes

aten/src/ATen/native/mps/operations/Repeat.mm Outdated Show resolved Hide resolved

albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 10, 2022

jazzysoggy requested a review from kulinseth November 14, 2022 13:02

kulinseth approved these changes Nov 16, 2022

View reviewed changes

jazzysoggy requested a review from kulinseth December 12, 2022 03:04

DenisVieriu97 force-pushed the repeat-interleave-mps branch from 64f0d14 to fd4155d Compare February 9, 2023 07:12

jazzysoggy added 9 commits February 11, 2023 17:50

Update Repeat.mm

3b1dccc

Update functionality

f858aa2

Changes

abd9e81

Update Repeat

a4ef979

Update Repeat

f54723a

Fix Repeat.mm

fb6deb2

Fix Repeat.mm

a61b747

Fix reapeats_shape

344535f

Fix Lint

294657b

jazzysoggy and others added 13 commits February 11, 2023 17:50

Fix compile issues

056ab22

Fix compile issues

da96229

Fix compile issues

40ead9f

Fix output issue

9dbfa3e

Fix unknown variable compile issue

dec1794

Fix lint

1c5cea8

Fix compile error

d6bc5f5

Fix compile issues

768ba77

Fix lint and test issues

07ea3f3

Fix test

d9957ea

Fix lint

327db5e

Update MPS Fallback

8f529e0

Fix build failures and metal kernel

99bb012

DenisVieriu97 force-pushed the repeat-interleave-mps branch from fd4155d to 99bb012 Compare February 12, 2023 03:40

DenisVieriu97 added 3 commits February 11, 2023 19:44

Revert MPSDevice and Repeat.cpp changes

828bbbe

Revert new lines / removed lines

6d1a47f

Fix comments

277bce4

DenisVieriu97 requested a review from razarmehr February 12, 2023 04:06

kulinseth approved these changes Feb 12, 2023

View reviewed changes

Fix lintrunner

9229982

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 12, 2023

pytorchmergebot added the Merged label Feb 12, 2023

pytorchmergebot closed this in fe0c7fb Feb 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MPS] Add repeat_interleave to MPS #88649

[MPS] Add repeat_interleave to MPS #88649

jazzysoggy commented Nov 8, 2022

pytorch-bot bot commented Nov 8, 2022 •

edited

kulinseth left a comment

kulinseth left a comment

kulinseth left a comment

kulinseth commented Nov 16, 2022

jazzysoggy commented Nov 19, 2022

kulinseth commented Dec 12, 2022

jazzysoggy commented Dec 12, 2022

jazzysoggy commented Dec 17, 2022

changeling commented Jan 26, 2023

changeling commented Feb 6, 2023

DenisVieriu97 commented Feb 9, 2023

DenisVieriu97 commented Feb 12, 2023

DenisVieriu97 commented Feb 12, 2023

pytorchmergebot commented Feb 12, 2023

pytorchmergebot commented Feb 12, 2023

changeling commented Feb 12, 2023

changeling commented Feb 14, 2023 •

edited

[MPS] Add repeat_interleave to MPS #88649

[MPS] Add repeat_interleave to MPS #88649

Conversation

jazzysoggy commented Nov 8, 2022

pytorch-bot bot commented Nov 8, 2022 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88649

✅ No Failures

kulinseth left a comment

Choose a reason for hiding this comment

kulinseth left a comment

Choose a reason for hiding this comment

kulinseth left a comment

Choose a reason for hiding this comment

kulinseth commented Nov 16, 2022

jazzysoggy commented Nov 19, 2022

kulinseth commented Dec 12, 2022

jazzysoggy commented Dec 12, 2022

‘’FAIL [13.217s]: test_no_warning_on_import (main.TestFallbackWarning) 3541

jazzysoggy commented Dec 17, 2022

FAIL [13.217s]: test_no_warning_on_import (main.TestFallbackWarning) 3541

changeling commented Jan 26, 2023

changeling commented Feb 6, 2023

DenisVieriu97 commented Feb 9, 2023

DenisVieriu97 commented Feb 12, 2023

DenisVieriu97 commented Feb 12, 2023

pytorchmergebot commented Feb 12, 2023

Merge started

pytorchmergebot commented Feb 12, 2023

changeling commented Feb 12, 2023

changeling commented Feb 14, 2023 • edited

pytorch-bot bot commented Nov 8, 2022 •

edited

‘’FAIL [13.217s]: test_no_warning_on_import (main.TestFallbackWarning)
3541

FAIL [13.217s]: test_no_warning_on_import (main.TestFallbackWarning)
3541

changeling commented Feb 14, 2023 •

edited