[nnc] Disable opaque pointers mode in LLVM backend to allow getPointerElementType #88798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rElementType [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88798
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 482760c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
bertmaher
added a commit
that referenced
this pull request
Nov 10, 2022
…rElementType ghstack-source-id: 350c13e8803a507fb8251251d28f79ef90bc14f6 Pull Request resolved: #88798
…w getPointerElementType" cc EikanWang jgong5 [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Nov 10, 2022
…rElementType ghstack-source-id: 6cfba69f27c320f1ac99b673e423131ae9741da4 Pull Request resolved: #88798
…w getPointerElementType" [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Nov 10, 2022
…rElementType ghstack-source-id: 6cfba69f27c320f1ac99b673e423131ae9741da4 Pull Request resolved: #88798
…w getPointerElementType" As of LLVM 15 typed pointers are going away: https://llvm.org/docs/OpaquePointers.html. Thus `getPointerElementType` is no longer legal, since pointers are all opaque. I don't totally remember why we use it so prolifically, or whether there's an easy change to get rid of it, or whether we'd need a significant refactor to carry around `Type`s alongside `Value`s. But in any case, NNC is deprecated (see: TorchInductor) and will hopefully be gone before LLVM 16 is a thing. For now, we can apply the hack of turning off opaque pointer mode on the LLVMContext. [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Nov 10, 2022
…rElementType As of LLVM 15 typed pointers are going away: https://llvm.org/docs/OpaquePointers.html. Thus `getPointerElementType` is no longer legal, since pointers are all opaque. I don't totally remember why we use it so prolifically, or whether there's an easy change to get rid of it, or whether we'd need a significant refactor to carry around `Type`s alongside `Value`s. But in any case, NNC is deprecated (see: TorchInductor) and will hopefully be gone before LLVM 16 is a thing. For now, we can apply the hack of turning off opaque pointer mode on the LLVMContext. ghstack-source-id: 6cfba69f27c320f1ac99b673e423131ae9741da4 Pull Request resolved: #88798
…w getPointerElementType" As of LLVM 15 typed pointers are going away: https://llvm.org/docs/OpaquePointers.html. Thus `getPointerElementType` is no longer legal, since pointers are all opaque. I don't totally remember why we use it so prolifically, or whether there's an easy change to get rid of it, or whether we'd need a significant refactor to carry around `Type`s alongside `Value`s. But in any case, NNC is deprecated (see: TorchInductor) and will hopefully be gone before LLVM 16 is a thing. For now, we can apply the hack of turning off opaque pointer mode on the LLVMContext. [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Nov 10, 2022
…rElementType As of LLVM 15 typed pointers are going away: https://llvm.org/docs/OpaquePointers.html. Thus `getPointerElementType` is no longer legal, since pointers are all opaque. I don't totally remember why we use it so prolifically, or whether there's an easy change to get rid of it, or whether we'd need a significant refactor to carry around `Type`s alongside `Value`s. But in any case, NNC is deprecated (see: TorchInductor) and will hopefully be gone before LLVM 16 is a thing. For now, we can apply the hack of turning off opaque pointer mode on the LLVMContext. ghstack-source-id: 6cfba69f27c320f1ac99b673e423131ae9741da4 Pull Request resolved: #88798
|
@bertmaher has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
desertfire
approved these changes
Nov 10, 2022
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…rElementType (pytorch#88798) As of LLVM 15 typed pointers are going away: https://llvm.org/docs/OpaquePointers.html. Thus `getPointerElementType` is no longer legal, since pointers are all opaque. I don't totally remember why we use it so prolifically, or whether there's an easy change to get rid of it, or whether we'd need a significant refactor to carry around `Type`s alongside `Value`s. But in any case, NNC is deprecated (see: TorchInductor) and will hopefully be gone before LLVM 16 is a thing. For now, we can apply the hack of turning off opaque pointer mode on the LLVMContext. Differential Revision: [D41176215](https://our.internmc.facebook.com/intern/diff/D41176215) Pull Request resolved: pytorch#88798 Approved by: https://github.com/desertfire
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Mar 10, 2023
…rElementType (pytorch#88798) As of LLVM 15 typed pointers are going away: https://llvm.org/docs/OpaquePointers.html. Thus `getPointerElementType` is no longer legal, since pointers are all opaque. I don't totally remember why we use it so prolifically, or whether there's an easy change to get rid of it, or whether we'd need a significant refactor to carry around `Type`s alongside `Value`s. But in any case, NNC is deprecated (see: TorchInductor) and will hopefully be gone before LLVM 16 is a thing. For now, we can apply the hack of turning off opaque pointer mode on the LLVMContext. Differential Revision: [D41176215](https://our.internmc.facebook.com/intern/diff/D41176215) Pull Request resolved: pytorch#88798 Approved by: https://github.com/desertfire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As of LLVM 15 typed pointers are going away:
https://llvm.org/docs/OpaquePointers.html. Thus
getPointerElementTypeis no longer legal, since pointers are allopaque. I don't totally remember why we use it so prolifically, or
whether there's an easy change to get rid of it, or whether we'd need
a significant refactor to carry around
Types alongsideValues.But in any case, NNC is deprecated (see: TorchInductor) and will
hopefully be gone before LLVM 16 is a thing. For now, we can apply
the hack of turning off opaque pointer mode on the LLVMContext.
Differential Revision: D41176215
cc @EikanWang @jgong5