[MPS] Support for median with dim #88807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88807
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fed16b0: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
albanD
added
the
triaged
[MPS] Support for median with dim Test cases for odd/even
Raman-Kumar
force-pushed
the
median_mps
branch
from
89db66b
to
fed16b0
Compare
|
Hi, @kulinseth As suggested in previous PR review now using is_macos_13_or_newer() for query to check macOS 13+ 🧪Added test case for if median at odd place and if at even place in test_median |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Nov 25, 2022
Closed
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
## Summary ⚡ **Aim**: Add support for aten::median for MPS backend (Fixes pytorch#87220) This is fresh clean PR from the previous [PR](pytorch#88554) - Implementing the new median function in aten/src/ATen/native/mps/operations/ReduceOps.mm - Adding it to aten/src/ATen/native/native_functions.yaml - Adding it to existing test_median ### **this will works like this** 🪶 median of entire input tensor on MPS `torch.median(mps_inputTensor)` median of along a dim `torch.median(mps_inputTensor, dim=[int], keepdim=[Bool])` Pull Request resolved: pytorch#88807 Approved by: https://github.com/kulinseth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary ⚡
Aim: Add support for aten::median for MPS backend (Fixes #87220)
This is fresh clean PR from the previous PR
this will works like this 🪶
median of entire input tensor on MPS
torch.median(mps_inputTensor)median of along a dim
torch.median(mps_inputTensor, dim=[int], keepdim=[Bool])