Fix XLA symbolic shapes binding #88928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obsoletes #88772 Mostly revolves around NOT assuming that the inside is a SymNode, but instead duck-typed to be a SymNode. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88928
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit f22d5d5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
bdhirsh,
Chillee,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
Obsoletes #88772 Mostly revolves around NOT assuming that the inside is a SymNode, but instead duck-typed to be a SymNode. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
ezyang
added
release notes: composability
|
cc @vanbasten23 |
| SYMNODE_UNARY(bool_) | ||
| SYMNODE_UNARY(int_) | ||
| SYMNODE_UNARY(sym_int) // TODO: remove me | ||
| SYMNODE_UNARY(sym_float) |
There was a problem hiding this comment.
in fact not missing, because this PR base is not recent enough to have sym_sqrt. I'll rebase
SherlockNoMad
approved these changes
Nov 12, 2022
Obsoletes #88772 Mostly revolves around NOT assuming that the inside is a SymNode, but instead duck-typed to be a SymNode. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
|
There's also some C++ related sym_int cleanup too now. |
|
@pytorchbot merge -f "flaky ci only" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Since all UT passed and no conflicts, can anyone help to merge it? thanks |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Obsoletes pytorch#88772 Mostly revolves around NOT assuming that the inside is a SymNode, but instead duck-typed to be a SymNode. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#88928 Approved by: https://github.com/SherlockNoMad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Obsoletes #88772
Mostly revolves around NOT assuming that the inside is a SymNode,
but instead duck-typed to be a SymNode.
Signed-off-by: Edward Z. Yang ezyang@fb.com