[reland][dynamo] Better support for nn.Module #88959
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88959
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 0c2230e: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64 / test (default, 2, 2, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "CI passed earlier, trunk failing with unrelated errors" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Broke |
@anijain2305 why did you think the failure was unrelated? It broke exactly the test it also broke in trunk, see https://hud.pytorch.org/minihud?name_filter=trunk%20/%20cuda11.6-py3.10-gcc7-sm86%20/%20test%20(default,%202,%204,%20linux.g5.4xlarge.nvidia.gpu) |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@anijain2305 your PR has been successfully reverted. |
This reverts commit e950afc. Reverted #88959 on behalf of https://github.com/malfet due to Broke `test_accuracy_issue1`
|
@malfet thanks for noticing this. The CI passed fully just 2 hours ago, and I ignored the trunk tests. I will be more careful next time |
|
@anijain2305 do you still have a link by any chance? (I.e. it sounds like you are telling this is a land race and I'm curious what might have caused it) |
Relanding pytorch#88629 Pull Request resolved: pytorch#88959 Approved by: https://github.com/msaroufim
This reverts commit e950afc. Reverted pytorch#88959 on behalf of https://github.com/malfet due to Broke `test_accuracy_issue1`
Relanding #88629
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire