Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in messages under aten #88964

Closed
wants to merge 2 commits into from
Closed

Fix typos in messages under aten #88964

wants to merge 2 commits into from

Conversation

kiszk
Copy link
Contributor

@kiszk kiszk commented Nov 13, 2022 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88964

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 899e20d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Nov 13, 2022
@github-actions github-actions bot added module: cpu CPU specific problem (e.g., perf, algorithm) oncall: quantization Quantization support in PyTorch labels Nov 13, 2022
@IvanYashchuk IvanYashchuk requested review from ezyang and removed request for IvanYashchuk November 14, 2022 08:00
lezcano
lezcano approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PRs are nice, but I believe that, at some point, we should have some sort of grammatical linter around...

@lezcano
Copy link
Collaborator

lezcano commented Nov 14, 2022

@pytorchbot merge -f "grammatical changes"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kiszk
Copy link
Contributor Author

kiszk commented Nov 14, 2022

The question is which part should we apply grammatical linter to.
Since there are many typos in comments, I intentionally skip to fix them.

@lezcano
Copy link
Collaborator

lezcano commented Nov 14, 2022

There could be a PR that fixes all the grammar issues with comments and docs, followed by one that adds the relevant linter to the lintrunner.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@kiszk @kulinseth
Fix typos in messages under aten (pytorch#88964)
5540571 
This PR fixes typos of messages and parms in c++ source files under `aten` directory.

Pull Request resolved: pytorch#88964
Approved by: https://github.com/lezcano
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezcano lezcano lezcano approved these changes

@nikitaved nikitaved Awaiting requested review from nikitaved

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

@z-a-f z-a-f Awaiting requested review from z-a-f

@salilsdesai salilsdesai Awaiting requested review from salilsdesai

@kimishpatel kimishpatel Awaiting requested review from kimishpatel

@digantdesai digantdesai Awaiting requested review from digantdesai

@jianyuh jianyuh Awaiting requested review from jianyuh

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
Merged module: cpu CPU specific problem (e.g., perf, algorithm) oncall: quantization Quantization support in PyTorch open source release notes: linalg_frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kiszk @lezcano @pytorchmergebot @pytorchbot