[UCC] Add pre & post processing for CPU collectives #89030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirteshpatil
requested review from
mrshenli,
zhaojuanmao,
pritamdamania87,
rohan-varma,
H-Huang,
awgu and
kwen2501
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89030
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 69f2156: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
pytorch-bot
bot
added
the
release notes: distributed (c10d)
|
This pull request was exported from Phabricator. Differential Revision: D41291592 |
kirteshpatil
added a commit
to kirteshpatil/pytorch
that referenced
this pull request
Nov 15, 2022
Summary: Pull Request resolved: pytorch#89030 The CPU block in `collective_post` was missing pre & post processing. The reduce-scatter implementaion expects use of pre-processing callback to flatten the input tensors, however, the missing invocation meant grabage values were being passed. Test Plan: Tested the reduce-scatter collective using PARAM Reviewed By: eastzone Differential Revision: D41291592 fbshipit-source-id: 9881745a04d950e7e169eb4d49aa818cb25488b0
kirteshpatil
force-pushed
the
export-D41291592
branch
from
db84c37
to
cb7f05b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41291592 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41291592 |
kirteshpatil
added a commit
to kirteshpatil/pytorch
that referenced
this pull request
Nov 15, 2022
Summary: Pull Request resolved: pytorch#89030 The CPU block in `collective_post` was missing pre & post processing. The reduce-scatter implementaion expects use of pre-processing callback to flatten the input tensors, however, the missing invocation meant grabage values were being passed. Test Plan: Tested the reduce-scatter collective using PARAM Reviewed By: eastzone, kingchc Differential Revision: D41291592 fbshipit-source-id: 2f7b318be6cbcab433070e1c88da3a9f69a187f1
kirteshpatil
force-pushed
the
export-D41291592
branch
from
cb7f05b
to
c605a42
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41291592 |
kirteshpatil
force-pushed
the
export-D41291592
branch
from
c605a42
to
a41e0c0
Compare
kirteshpatil
added a commit
to kirteshpatil/pytorch
that referenced
this pull request
Nov 15, 2022
Summary: Pull Request resolved: pytorch#89030 The CPU block in `collective_post` was missing pre & post processing. The reduce-scatter implementaion expects use of pre-processing callback to flatten the input tensors, however, the missing invocation meant grabage values were being passed. Test Plan: Tested the reduce-scatter collective using PARAM Reviewed By: eastzone, kingchc Differential Revision: D41291592 fbshipit-source-id: 6f6e29e5585db43b87740ae35e1a7c24781f08e1
kingchc
approved these changes
Nov 15, 2022
|
/easycla |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-x86-64 / test (default, 2, 2, macos-12) Details for Dev Infra teamRaised by workflow job |
Summary: Pull Request resolved: pytorch#89030 The CPU block in `collective_post` was missing pre & post processing. The reduce-scatter implementaion expects use of pre-processing callback to flatten the input tensors, however, the missing invocation meant grabage values were being passed. Test Plan: Tested the reduce-scatter collective using PARAM Reviewed By: eastzone, kingchc Differential Revision: D41291592 fbshipit-source-id: c8e7a639d78039951d85e33509ac141934a8c837
kirteshpatil
force-pushed
the
export-D41291592
branch
from
a41e0c0
to
69f2156
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41291592 |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: The CPU block in `collective_post` was missing pre & post processing. The reduce-scatter implementaion expects use of pre-processing callback to flatten the input tensors, however, the missing invocation meant grabage values were being passed. Test Plan: Tested the reduce-scatter collective using PARAM Reviewed By: eastzone Differential Revision: D41291592 Pull Request resolved: pytorch#89030 Approved by: https://github.com/kingchc, https://github.com/kwen2501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The CPU block in
collective_postwas missing pre & post processing. The reduce-scatter implementaion expects use of pre-processing callback to flatten the input tensors, however, the missing invocation meant grabage values were being passed.Test Plan: Tested the reduce-scatter collective using PARAM
Reviewed By: eastzone
Differential Revision: D41291592