[FSDP] Include module classes in ModuleWrapPolicy.__repr__
#89058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
requested review from
mrshenli,
zhaojuanmao,
pritamdamania87,
rohan-varma,
H-Huang and
kwen2501
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89058
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1c982b1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
awgu
added a commit
that referenced
this pull request
Nov 15, 2022
ghstack-source-id: 88c6116153ada8366264d37649ff32964730a11b Pull Request resolved: #89058
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Nov 23, 2022
ghstack-source-id: 88c6116153ada8366264d37649ff32964730a11b Pull Request resolved: pytorch#89058
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Nov 29, 2022
ghstack-source-id: 88c6116153ada8366264d37649ff32964730a11b Pull Request resolved: pytorch#89058
Before:
```
<torch.distributed.fsdp.wrap.ModuleWrapPolicy object at 0x7fd4280f0fd0>
```
After:
```
<torch.distributed.fsdp.wrap.ModuleWrapPolicy object at 0x7fd4280f0fd0>({<class 'transformers.models.t5.modeling_t5.T5Block'>})
```
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Nov 29, 2022
ghstack-source-id: 9414cc7bbacaa3757e63ce98e055260d681db677 Pull Request resolved: #89058
mrshenli
approved these changes
Nov 29, 2022
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…#89058) Before: ``` <torch.distributed.fsdp.wrap.ModuleWrapPolicy object at 0x7fd4280f0fd0> ``` After: ``` <torch.distributed.fsdp.wrap.ModuleWrapPolicy object at 0x7fd4280f0fd0>({<class 'transformers.models.t5.modeling_t5.T5Block'>}) ``` Pull Request resolved: pytorch#89058 Approved by: https://github.com/mrshenli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ModuleWrapPolicy.__repr__#89058 [FSDP] Include module classes inModuleWrapPolicy.__repr__Before:
After: