Fix torch.nn.functional.gelu docstring formatting #89061
Conversation
Typo in torch.fx.Interpreter.fetch_attr docs
Unify and correct the description of what kind of pooling is added in MaxPool2d and MaxPool3d
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89061
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 5dff32f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The pytorch bot comment (#89061 (comment)) gives a link to the built docs, which I confirmed look better now. |
|
@pytorchbot merge |
Merge failedReason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at: Details for Dev Infra teamRaised by workflow job |
Thanks, I suppose I wasn't patient enough. When I checked it showed me an error, which made me suspect I didn't have permission or something, but now it works. |
|
While we're at it: Is it intended that the square-root in the GELU formula isn't ranging over the whole |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The docstring of `torch.nn.functional.gelu` is formatted incorrectly, so that part of the math isn't rendered and there are extra blocks when there shouldn't: https://pytorch.org/docs/stable/generated/torch.nn.functional.gelu.html I didn't build the docs, so I am not 100% sure that I got the formatting right, but I am confident. Pull Request resolved: pytorch#89061 Approved by: https://github.com/bdhirsh, https://github.com/kit1980
The docstring of
torch.nn.functional.geluis formatted incorrectly, so that part of the math isn't rendered and there are extra blocks when there shouldn't: https://pytorch.org/docs/stable/generated/torch.nn.functional.gelu.htmlI didn't build the docs, so I am not 100% sure that I got the formatting right, but I am confident.